Skip to content

⚡️ Speed up method PropertyValueList.__iadd__ by 16% #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up method PropertyValueList.__iadd__ by 16% #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/bokeh/core/property/wrappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,9 @@ class PropertyValueList(PropertyValueContainer, list[T]):
"""

def __init__(self, *args, **kwargs) -> None:
super().__init__(*args, **kwargs)
# Directly call list's __init__ then PropertyValueContainer's __init__, avoiding super() MRO
list.__init__(self, *args, **kwargs)
PropertyValueContainer.__init__(self)

def _saved_copy(self) -> list[T]:
return list(self)
Expand All @@ -227,7 +229,8 @@ def __delitem__(self, y):
# x += y
@notify_owner
def __iadd__(self, y):
return super().__iadd__(y)
# Avoid super() to save method resolution time in simple scenarios
return list.__iadd__(self, y)

# x *= y
@notify_owner
Expand Down