fix: address PR review — hoist pruning above loop, add warning on repair failure

Author: KRRT7

codeflash/optimization/function_optimizer.py

@@ -1963,6 +1963,15 @@ def review_and_repair_tests(
         behavioral_results: TestResults | None = None
         coverage_results: CoverageData | None = None
         previous_repair_errors: dict[int, dict[str, str]] = {}
+        # Apply token limit to function source (same progressive fallback as optimization/testgen context)
+        function_source_for_prompt = self.function_to_optimize_source_code
+        if encoded_tokens_len(function_source_for_prompt) > OPTIMIZATION_CONTEXT_TOKEN_LIMIT:
+            logger.debug("Function source exceeds token limit for review, extracting function only")
+            func = self.function_to_optimize
+            source_lines = self.function_to_optimize_source_code.splitlines(keepends=True)
+            func_start = (func.doc_start_line or func.starting_line or 1) - 1
+            func_end = func.ending_line or len(source_lines)
+            function_source_for_prompt = "".join(source_lines[func_start:func_end])
         max_cycles = getattr(self.args, "testgen_review_turns", None) or MAX_TEST_REPAIR_CYCLES
         for cycle in range(max_cycles):
             with progress_bar("Running generated tests to validate quality..."):
@@ -2026,16 +2035,6 @@ def review_and_repair_tests(
                         "unexecuted_branches": dc.unexecuted_branches,
                     }
 
-            # Apply token limit to function source (same progressive fallback as optimization/testgen context)
-            function_source_for_prompt = self.function_to_optimize_source_code
-            if encoded_tokens_len(function_source_for_prompt) > OPTIMIZATION_CONTEXT_TOKEN_LIMIT:
-                logger.debug("Function source exceeds token limit for review, extracting function only")
-                func = self.function_to_optimize
-                source_lines = self.function_to_optimize_source_code.splitlines(keepends=True)
-                func_start = (func.doc_start_line or func.starting_line or 1) - 1
-                func_end = func.ending_line or len(source_lines)
-                function_source_for_prompt = "".join(source_lines[func_start:func_end])
-
             console.rule()
             with progress_bar("Reviewing generated tests for quality issues..."):
                 review_results = self.aiservice_client.review_generated_tests(
@@ -2143,6 +2142,7 @@ def review_and_repair_tests(
                     repaired_indices.add(review.test_index)
 
             if not any_repaired:
+                logger.warning("All repair API calls failed; proceeding with unrepaired tests")
                 break
 
             generated_tests = self.language_support.postprocess_generated_tests(