refactor: move OptimizationReviewResult to models.py

Better placement with other data models and AI service request/response types.

Author: KRRT7

codeflash/api/aiservice.py

@@ -5,7 +5,7 @@
 import platform
 import time
 from itertools import count
-from typing import TYPE_CHECKING, Any, NamedTuple, cast
+from typing import TYPE_CHECKING, Any, cast
 
 import requests
 from pydantic.json import pydantic_encoder
@@ -23,6 +23,7 @@
     CodeStringsMarkdown,
     OptimizedCandidate,
     OptimizedCandidateSource,
+    OptimizationReviewResult,
 )
 from codeflash.telemetry.posthog_cf import ph
 from codeflash.version import __version__ as codeflash_version
@@ -40,13 +41,6 @@
     from codeflash.result.explanation import Explanation
 
 
-class OptimizationReviewResult(NamedTuple):
-    """Result from the optimization review API."""
-
-    review: str  # "high", "medium", "low", or ""
-    explanation: str
-
-
 class AiServiceClient:
     def __init__(self) -> None:
         self.base_url = self.get_aiservice_base_url()

codeflash/models/models.py

@@ -20,7 +20,7 @@
 from enum import Enum, IntEnum
 from pathlib import Path
 from re import Pattern
-from typing import Annotated, Optional, cast
+from typing import Annotated, NamedTuple, Optional, cast
 
 from jedi.api.classes import Name
 from pydantic import AfterValidator, BaseModel, ConfigDict, Field, PrivateAttr, ValidationError
@@ -95,6 +95,13 @@ class AIServiceCodeRepairRequest:
     test_diffs: list[TestDiff]
 
 
+class OptimizationReviewResult(NamedTuple):
+    """Result from the optimization review API."""
+
+    review: str  # "high", "medium", "low", or ""
+    explanation: str
+
+
 # If the method spam is in the class Ham, which is at the top level of the module eggs in the package foo, the fully
 # qualified name of the method is foo.eggs.Ham.spam, its qualified name is Ham.spam, and its name is spam. The full name
 # of the module is foo.eggs.

codeflash/optimization/function_optimizer.py

@@ -17,12 +17,7 @@
 from rich.syntax import Syntax
 from rich.tree import Tree
 
-from codeflash.api.aiservice import (
-    AiServiceClient,
-    AIServiceRefinerRequest,
-    LocalAiServiceClient,
-    OptimizationReviewResult,
-)
+from codeflash.api.aiservice import AiServiceClient, AIServiceRefinerRequest, LocalAiServiceClient
 from codeflash.api.cfapi import add_code_context_hash, create_staging, get_cfapi_base_urls, mark_optimization_success
 from codeflash.benchmarking.utils import process_benchmark_data
 from codeflash.cli_cmds.console import code_print, console, logger, lsp_log, progress_bar
@@ -90,6 +85,7 @@
     CodeOptimizationContext,
     GeneratedTests,
     GeneratedTestsList,
+    OptimizationReviewResult,
     OptimizationSet,
     OptimizedCandidate,
     OptimizedCandidateResult,