You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge branch 'main' into fix/js-jest30-loop-runner
Resolved conflicts by:
1. Accepting origin/main's refactored verify_requirements() in support.py
- Uses centralized find_node_modules_with_package() from init_javascript.py
- Cleaner monorepo dependency detection
2. Accepting origin/main's refactored Jest parsing in parse_test_output.py
- Jest-specific parsing moved to new codeflash/languages/javascript/parse.py
- parse_test_xml() now routes to _parse_jest_test_xml() for JavaScript
3. Fixed TestType.GENERATED_PERFORMANCE bug in new parse.py
- Changed to TestType.GENERATED_REGRESSION (performance tests are regression tests)
- This was part of the original fixes in this branch
The merge preserves all the infrastructure fixes from this branch while
adopting the cleaner code organization from main.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
First, run `uv run prek run --from-ref origin/main` to check for linting/formatting issues on files changed in this PR.
59
+
First, run these checks on files changed in this PR:
60
+
1. `uv run prek run --from-ref origin/main` - linting/formatting issues
61
+
2. `uv run mypy <changed_files>` - type checking issues
60
62
61
-
If there are any issues:
63
+
If there are prek issues:
62
64
- For SAFE auto-fixable issues (formatting, import sorting, trailing whitespace, etc.), run `uv run prek run --from-ref origin/main` again to auto-fix them
65
+
66
+
If there are mypy issues:
67
+
- Fix type annotation issues (missing return types, Optional/None unions, import errors for type hints, incorrect types)
68
+
- Do NOT add `type: ignore` comments - always fix the root cause
69
+
70
+
After fixing issues:
63
71
- Stage the fixed files with `git add`
64
-
- Commit with message "style: auto-fix linting issues"
72
+
- Commit with message "style: auto-fix linting issues" or "fix: resolve mypy type errors" as appropriate
65
73
- Push the changes with `git push`
66
74
67
75
Do NOT attempt to fix:
68
-
- Type errors that require logic changes
69
-
- Complex refactoring suggestions
70
-
- Anything that could change behavior
76
+
- Type errors that require logic changes or refactoring
77
+
- Complex generic type issues
78
+
- Anything that could change runtime behavior
71
79
72
80
## STEP 2: Review the PR
73
81
@@ -85,7 +93,6 @@ jobs:
85
93
- Only create NEW inline comments for HIGH-PRIORITY issues found in changed files.
86
94
- Limit to 5-7 NEW comments maximum per review.
87
95
- Use CLAUDE.md for project-specific guidance.
88
-
- Use `gh pr comment` for summary-level feedback.
89
96
- Use `mcp__github_inline_comment__create_inline_comment` sparingly for critical code issues only.
90
97
91
98
## STEP 3: Coverage analysis
@@ -122,7 +129,45 @@ jobs:
122
129
- New implementations/files: Must have ≥75% test coverage
123
130
- Modified code: Changed lines should be exercised by existing or new tests
124
131
- No coverage regressions: Overall coverage should not decrease
125
-
claude_args: '--allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*),Bash(gh issue view:*),Bash(gh issue list:*),Bash(gh api:*),Bash(uv run prek *),Bash(uv run coverage *),Bash(uv run pytest *),Bash(git status*),Bash(git add *),Bash(git commit *),Bash(git push*),Bash(git diff *),Bash(git checkout *),Read,Glob,Grep"'
132
+
133
+
## STEP 4: Post ONE consolidated summary comment
134
+
135
+
CRITICAL: You must post exactly ONE summary comment containing ALL results (pre-commit, review, coverage).
136
+
DO NOT post multiple separate comments. Use this format:
0 commit comments