Merge pull request #1216 from codeflash-ai/fix/nested-progress-bar-error

fix: avoid nested progress bars causing LiveError

Author: misrasaurabh1

codeflash/cli_cmds/console.py

@@ -129,6 +129,9 @@ def code_print(
 
 spinners = cycle(SPINNER_TYPES)
 
+# Track whether a progress bar is already active to prevent nested Live displays
+_progress_bar_active = False
+
 
 @contextmanager
 def progress_bar(
@@ -138,28 +141,38 @@ def progress_bar(
 
     If revert_to_print is True, falls back to printing a single logger.info message
     instead of showing a progress bar.
+
+    If a progress bar is already active, yields a dummy task ID to avoid Rich's
+    LiveError from nested Live displays.
     """
+    global _progress_bar_active
+
     if is_LSP_enabled():
         lsp_log(LspTextMessage(text=message, takes_time=True))
         yield
         return
 
-    if revert_to_print:
-        logger.info(message)
+    if revert_to_print or _progress_bar_active:
+        if revert_to_print:
+            logger.info(message)
 
         # Create a fake task ID since we still need to yield something
         yield DummyTask().id
     else:
-        progress = Progress(
-            SpinnerColumn(next(spinners)),
-            *Progress.get_default_columns(),
-            TimeElapsedColumn(),
-            console=console,
-            transient=transient,
-        )
-        task = progress.add_task(message, total=None)
-        with progress:
-            yield task
+        _progress_bar_active = True
+        try:
+            progress = Progress(
+                SpinnerColumn(next(spinners)),
+                *Progress.get_default_columns(),
+                TimeElapsedColumn(),
+                console=console,
+                transient=transient,
+            )
+            task = progress.add_task(message, total=None)
+            with progress:
+                yield task
+        finally:
+            _progress_bar_active = False
 
 
 @contextmanager

tests/test_languages/test_js_code_replacer.py

@@ -167,12 +167,12 @@ def test_convert_destructured_require(self):
             f"CJS to ESM conversion failed.\nInput: {code}\nExpected: {expected}\nGot: {result}"
         )
 
-    def test_convert_relative_require_adds_extension(self):
-        """Test that relative imports get .js extension added - exact output."""
+    def test_convert_relative_require_preserves_path(self):
+        """Test that relative imports preserve the original path without adding extension."""
         code = "const { helper } = require('./utils');"
         result = convert_commonjs_to_esm(code)
 
-        expected = "import { helper } from './utils.js';"
+        expected = "import { helper } from './utils';"
         assert result.strip() == expected, (
             f"CJS to ESM conversion failed.\nInput: {code}\nExpected: {expected}\nGot: {result}"
         )
@@ -182,7 +182,7 @@ def test_convert_property_access_require(self):
         code = "const myHelper = require('./utils').helperFunction;"
         result = convert_commonjs_to_esm(code)
 
-        expected = "import { helperFunction as myHelper } from './utils.js';"
+        expected = "import { helperFunction as myHelper } from './utils';"
         assert result.strip() == expected, (
             f"CJS to ESM conversion failed.\nInput: {code}\nExpected: {expected}\nGot: {result}"
         )
@@ -192,7 +192,7 @@ def test_convert_default_property_access(self):
         code = "const MyClass = require('./class').default;"
         result = convert_commonjs_to_esm(code)
 
-        expected = "import MyClass from './class.js';"
+        expected = "import MyClass from './class';"
         assert result.strip() == expected, (
             f"CJS to ESM conversion failed.\nInput: {code}\nExpected: {expected}\nGot: {result}"
         )
@@ -207,7 +207,7 @@ def test_convert_multiple_requires(self):
         result = convert_commonjs_to_esm(code)
 
         expected = """\
-import { add, subtract } from './math.js';
+import { add, subtract } from './math';
 import lodash from 'lodash';
 import path from 'path';"""
 
@@ -316,7 +316,7 @@ def test_convert_mixed_code_to_esm(self):
         result = ensure_module_system_compatibility(code, ModuleSystem.ES_MODULE)
 
         # Should convert require to import
-        assert "import { helper } from './helpers.js';" in result
+        assert "import { helper } from './helpers';" in result
         assert "require" not in result, f"require should be converted to import. Got:\n{result}"
 
     def test_convert_mixed_code_to_commonjs(self):