fix linting

Author: mohamedashrraf222

codeflash/code_utils/git_worktree_utils.py

@@ -127,6 +127,7 @@ def remove_worktree(worktree_dir: Path) -> None:
         # If we can't access the repository, try manual cleanup
         # Log at debug level since this is expected in some edge cases
         from codeflash.cli_cmds.console import logger
+
         logger.debug(f"Could not access git repository at {worktree_dir}: {e}. Attempting manual cleanup.")
         _manual_cleanup_worktree_directory(worktree_dir)
         return
@@ -150,6 +151,7 @@ def remove_worktree(worktree_dir: Path) -> None:
         except (OSError, PermissionError) as e:
             # Log unexpected errors for debugging
             from codeflash.cli_cmds.console import logger
+
             logger.debug(f"Worktree removal attempt {attempt + 1} failed with unexpected error: {e}")
             break
 

codeflash/discovery/discover_unit_tests.py

@@ -606,7 +606,7 @@ def discover_tests_pytest(
                 check=False,
                 **run_kwargs,
             )
-        except subprocess.TimeoutExpired as e:
+        except subprocess.TimeoutExpired:
             logger.error(
                 f"Test discovery subprocess timed out after {run_kwargs.get('timeout', 600)} seconds. "
                 f"Command: {discovery_script}"

codeflash/discovery/functions_to_optimize.py

@@ -667,52 +667,54 @@ def filter_functions(
 
     def _validate_path_no_traversal(path: Path | str) -> bool:
         """Validate that a path does not contain path traversal components.
-        
+
         This prevents path traversal attacks by rejecting paths with '..' components.
         Paths passed to this function should be from trusted sources (git operations,
         file system discovery), but we validate defensively.
-        
+
         Args:
             path: Path to validate
-            
+
         Returns:
             True if path is safe (no traversal components), False otherwise
+
         """
         path_str = str(path)
         # Check for path traversal attempts
-        if ".." in path_str:
-            return False
         # Check for absolute paths that might escape (additional safety check)
         # Note: We allow absolute paths as they're needed for worktree paths
-        return True
+        return ".." not in path_str
 
     def _resolve_path(path: Path | str) -> Path:
         # Use strict=False so we don't fail on paths that don't exist yet (e.g. worktree paths)
         # SECURITY: Validate path before resolution to prevent traversal attacks
         if not _validate_path_no_traversal(path):
-            raise ValueError(f"Path contains traversal components: {path}")
+            error_msg = f"Path contains traversal components: {path}"
+            raise ValueError(error_msg)
         return Path(path).resolve(strict=False)
 
     def _resolve_path_consistent(path: Path | str) -> Path:
         """Resolve path consistently: use strict resolution if path exists, otherwise non-strict.
-        
+
         SECURITY: This function validates paths to prevent traversal attacks before resolution.
         Paths should come from trusted sources (git operations, file system discovery),
         but we validate defensively.
-        
+
         Args:
             path: Path to resolve (from trusted sources like git diff or file discovery)
-            
+
         Returns:
             Resolved absolute Path
-            
+
         Raises:
             ValueError: If path contains traversal components
+
         """
         # SECURITY: Validate path before any resolution to prevent traversal attacks
         if not _validate_path_no_traversal(path):
-            raise ValueError(f"Path contains traversal components: {path}")
-            
+            error_msg = f"Path contains traversal components: {path}"
+            raise ValueError(error_msg)
+
         path_obj = Path(path)
         if path_obj.exists():
             try: