Merge pull request #1914 from codeflash-ai/remove-python-version-field

Remove python_version from API payloads, use language_version

Author: KRRT7

codeflash/api/aiservice.py

@@ -2,7 +2,6 @@
 
 import json
 import os
-import platform
 import time
 from itertools import count
 from typing import TYPE_CHECKING, Any, cast
@@ -62,7 +61,6 @@ def add_language_metadata(
         if language_version is None:
             language_version = current_language_support().language_version
         payload["language_version"] = language_version
-        payload["python_version"] = language_version if current_language() == Language.PYTHON else None
 
         if current_language() != Language.PYTHON:
             if module_system:
@@ -270,7 +268,6 @@ def optimize_python_code_line_profiler(
             "trace_id": trace_id,
             "language": language,
             "language_version": language_version,
-            "python_version": language_version if current_language() == Language.PYTHON else None,
             "experiment_metadata": experiment_metadata,
             "codeflash_version": codeflash_version,
             "call_sequence": self.get_next_sequence(),
@@ -534,7 +531,6 @@ def generate_ranking(
             "diffs": diffs,
             "speedups": speedups,
             "optimization_ids": optimization_ids,
-            "python_version": platform.python_version(),  # backward compat
             "function_references": function_references,
         }
         logger.info("loading|Generating ranking")
@@ -843,8 +839,7 @@ def get_optimization_review(
             "codeflash_version": codeflash_version,
             "calling_fn_details": calling_fn_details,
             "language": language,
-            "language_version": platform.python_version() if current_language() == Language.PYTHON else None,
-            "python_version": platform.python_version() if current_language() == Language.PYTHON else None,
+            "language_version": current_language_support().language_version,
             "call_sequence": self.get_next_sequence(),
         }
         console.rule()

tests/test_add_language_metadata.py

@@ -18,12 +18,11 @@ class TestAddLanguageMetadata:
     """Test add_language_metadata sets correct payload fields per language."""
 
     @patch("codeflash.api.aiservice.current_language", return_value=Language.PYTHON)
-    def test_python_sets_language_version_and_python_version(self, _mock_lang: object) -> None:
-        """For Python, both language_version and python_version should be set to the same value."""
+    def test_python_sets_language_version(self, _mock_lang: object) -> None:
+        """For Python, language_version should be set."""
         payload: dict = {}
         AiServiceClient.add_language_metadata(payload, language_version="3.11.5")
         assert payload["language_version"] == "3.11.5"
-        assert payload["python_version"] == "3.11.5"
         assert "module_system" not in payload
 
     @patch("codeflash.api.aiservice.current_language", return_value=Language.PYTHON)
@@ -34,12 +33,11 @@ def test_python_no_module_system(self, _mock_lang: object) -> None:
         assert "module_system" not in payload
 
     @patch("codeflash.api.aiservice.current_language", return_value=Language.JAVA)
-    def test_java_sets_language_version_not_python_version(self, _mock_lang: object) -> None:
-        """For Java, language_version should be set, python_version should be None."""
+    def test_java_sets_language_version(self, _mock_lang: object) -> None:
+        """For Java, language_version should be set."""
         payload: dict = {}
         AiServiceClient.add_language_metadata(payload, language_version="17")
         assert payload["language_version"] == "17"
-        assert payload["python_version"] is None
 
     @patch("codeflash.api.aiservice.current_language", return_value=Language.JAVA)
     def test_java_includes_module_system(self, _mock_lang: object) -> None:
@@ -56,12 +54,11 @@ def test_java_no_module_system_when_none(self, _mock_lang: object) -> None:
         assert "module_system" not in payload
 
     @patch("codeflash.api.aiservice.current_language", return_value=Language.JAVASCRIPT)
-    def test_javascript_sets_language_version_not_python_version(self, _mock_lang: object) -> None:
-        """For JavaScript, language_version should be set, python_version should be None."""
+    def test_javascript_sets_language_version(self, _mock_lang: object) -> None:
+        """For JavaScript, language_version should be set."""
         payload: dict = {}
         AiServiceClient.add_language_metadata(payload, language_version="20.11.0")
         assert payload["language_version"] == "20.11.0"
-        assert payload["python_version"] is None
 
     @patch("codeflash.api.aiservice.current_language", return_value=Language.JAVASCRIPT)
     def test_javascript_includes_module_system(self, _mock_lang: object) -> None:
@@ -76,7 +73,6 @@ def test_typescript_same_as_javascript(self, _mock_lang: object) -> None:
         payload: dict = {}
         AiServiceClient.add_language_metadata(payload, language_version="20.11.0", module_system="commonjs")
         assert payload["language_version"] == "20.11.0"
-        assert payload["python_version"] is None
         assert payload["module_system"] == "commonjs"
 
     @patch("codeflash.api.aiservice.current_language", return_value=Language.PYTHON)
@@ -87,7 +83,6 @@ def test_none_language_version_python_auto_detects(self, mock_support: MagicMock
         payload: dict = {}
         AiServiceClient.add_language_metadata(payload, language_version=None)
         assert payload["language_version"] == "3.12.0"
-        assert payload["python_version"] == "3.12.0"
 
     @patch("codeflash.api.aiservice.current_language", return_value=Language.JAVA)
     @patch("codeflash.api.aiservice.current_language_support")
@@ -97,4 +92,3 @@ def test_none_language_version_java_auto_detects(self, mock_support: MagicMock,
         payload: dict = {}
         AiServiceClient.add_language_metadata(payload, language_version=None)
         assert payload["language_version"] == "17"
-        assert payload["python_version"] is None