Merge pull request #1238 from codeflash-ai/pre-check_on_environment_config_dependencies

Pre check on env config dependencies in JS before calling aiservices API

Author: Saga4

codeflash/languages/javascript/support.py

@@ -19,7 +19,6 @@
     HelperFunction,
     Language,
     ParentInfo,
-    ReferenceInfo,
     TestInfo,
     TestResult,
 )
@@ -29,6 +28,7 @@
 if TYPE_CHECKING:
     from collections.abc import Sequence
 
+    from codeflash.languages.base import ReferenceInfo
     from codeflash.languages.treesitter_utils import TypeDefinition
 
 logger = logging.getLogger(__name__)
@@ -966,11 +966,7 @@ def find_helper_functions(self, function: FunctionInfo, project_root: Path) -> l
             return []
 
     def find_references(
-        self,
-        function: FunctionInfo,
-        project_root: Path,
-        tests_root: Path | None = None,
-        max_files: int = 500,
+        self, function: FunctionInfo, project_root: Path, tests_root: Path | None = None, max_files: int = 500
     ) -> list[ReferenceInfo]:
         """Find all references (call sites) to a function across the codebase.
 
@@ -1835,51 +1831,98 @@ def get_module_path(self, source_file: Path, project_root: Path, tests_root: Pat
             rel_path = source_file.relative_to(project_root)
             return "../" + rel_path.with_suffix("").as_posix()
 
+    def verify_requirements(self, project_root: Path, test_framework: str = "jest") -> tuple[bool, list[str]]:
+        """Verify that all JavaScript requirements are met.
+
+        Checks for:
+        1. Node.js installation
+        2. npm availability
+        3. Test framework (jest/vitest) installation
+        4. node_modules existence
+
+        Args:
+            project_root: The project root directory.
+            test_framework: The test framework to check for ("jest" or "vitest").
+
+        Returns:
+            Tuple of (success, list of error messages).
+
+        """
+        errors: list[str] = []
+
+        # Check Node.js
+        try:
+            result = subprocess.run(["node", "--version"], check=False, capture_output=True, text=True, timeout=10)
+            if result.returncode != 0:
+                errors.append("Node.js is not installed. Please install Node.js 18+ from https://nodejs.org/")
+        except FileNotFoundError:
+            errors.append("Node.js is not installed. Please install Node.js 18+ from https://nodejs.org/")
+        except Exception as e:
+            errors.append(f"Failed to check Node.js: {e}")
+
+        # Check npm
+        try:
+            result = subprocess.run(["npm", "--version"], check=False, capture_output=True, text=True, timeout=10)
+            if result.returncode != 0:
+                errors.append("npm is not available. Please ensure npm is installed with Node.js.")
+        except FileNotFoundError:
+            errors.append("npm is not available. Please ensure npm is installed with Node.js.")
+        except Exception as e:
+            errors.append(f"Failed to check npm: {e}")
+
+        # Check node_modules exists
+        node_modules = project_root / "node_modules"
+        if not node_modules.exists():
+            errors.append(
+                f"node_modules not found in {project_root}. Please run 'npm install' to install dependencies."
+            )
+        else:
+            # Check test framework is installed
+            framework_path = node_modules / test_framework
+            if not framework_path.exists():
+                errors.append(
+                    f"{test_framework} is not installed. "
+                    f"Please run 'npm install --save-dev {test_framework}' to install it."
+                )
+
+        return len(errors) == 0, errors
+
     def ensure_runtime_environment(self, project_root: Path) -> bool:
         """Ensure codeflash npm package is installed.
 
         Attempts to install the npm package for test instrumentation.
-        Falls back to copying files if npm install fails.
 
         Args:
             project_root: The project root directory.
 
         Returns:
-            True if npm package is installed, False if falling back to file copy.
+            True if npm package is installed, False otherwise.
 
         """
-        import subprocess
-
         from codeflash.cli_cmds.console import logger
 
-        # Check if package is already installed
         node_modules_pkg = project_root / "node_modules" / "codeflash"
         if node_modules_pkg.exists():
             logger.debug("codeflash already installed")
             return True
 
-        # Try to install from local package first (for development)
-        local_package_path = Path(__file__).parent.parent.parent.parent / "packages" / "cli"
-        if local_package_path.exists():
-            try:
-                result = subprocess.run(
-                    ["npm", "install", "--save-dev", str(local_package_path)],
-                    check=False,
-                    cwd=project_root,
-                    capture_output=True,
-                    text=True,
-                    timeout=120,
-                )
-                if result.returncode == 0:
-                    logger.debug("Installed codeflash from local package")
-                    return True
-                logger.warning(f"Failed to install local package: {result.stderr}")
-            except Exception as e:
-                logger.warning(f"Error installing local package: {e}")
-
-        # Could try npm registry here in the future:
-        # subprocess.run(["npm", "install", "--save-dev", "codeflash"], ...)
+        try:
+            result = subprocess.run(
+                ["npm", "install", "--save-dev", "codeflash"],
+                check=False,
+                cwd=project_root,
+                capture_output=True,
+                text=True,
+                timeout=120,
+            )
+            if result.returncode == 0:
+                logger.debug("Installed codeflash from npm registry")
+                return True
+            logger.warning(f"Failed to install codeflash: {result.stderr}")
+        except Exception as e:
+            logger.warning(f"Error installing codeflash: {e}")
 
+        logger.error("Could not install codeflash. Please run: npm install --save-dev codeflash")
         return False
 
     def instrument_existing_test(

codeflash/languages/javascript/test_runner.py

@@ -150,32 +150,11 @@ def _ensure_runtime_files(project_root: Path) -> None:
         project_root: The project root directory.
 
     """
-    # Check if package is already installed
     node_modules_pkg = project_root / "node_modules" / "codeflash"
     if node_modules_pkg.exists():
         logger.debug("codeflash already installed")
         return
 
-    # Try to install from local package first (for development)
-    local_package_path = Path(__file__).parent.parent.parent.parent / "packages" / "codeflash"
-    if local_package_path.exists():
-        try:
-            result = subprocess.run(
-                ["npm", "install", "--save-dev", str(local_package_path)],
-                check=False,
-                cwd=project_root,
-                capture_output=True,
-                text=True,
-                timeout=120,
-            )
-            if result.returncode == 0:
-                logger.debug("Installed codeflash from local package")
-                return
-            logger.warning(f"Failed to install local package: {result.stderr}")
-        except Exception as e:
-            logger.warning(f"Error installing local package: {e}")
-
-    # Try to install from npm registry
     try:
         result = subprocess.run(
             ["npm", "install", "--save-dev", "codeflash"],

codeflash/optimization/optimizer.py

@@ -90,6 +90,33 @@ def _find_js_project_root(file_path: Path) -> Path | None:
             current = current.parent
         return None
 
+    def _verify_js_requirements(self) -> None:
+        """Verify JavaScript/TypeScript requirements before optimization.
+
+        Checks that Node.js, npm, and the test framework are available.
+        Logs warnings if requirements are not met but does not abort.
+
+        """
+        from codeflash.languages import get_language_support
+        from codeflash.languages.base import Language
+        from codeflash.languages.test_framework import get_js_test_framework_or_default
+
+        js_project_root = self.test_cfg.js_project_root
+        if not js_project_root:
+            return
+
+        try:
+            js_support = get_language_support(Language.JAVASCRIPT)
+            test_framework = get_js_test_framework_or_default()
+            success, errors = js_support.verify_requirements(js_project_root, test_framework)
+
+            if not success:
+                logger.warning("JavaScript requirements check found issues:")
+                for error in errors:
+                    logger.warning(f"  - {error}")
+        except Exception as e:
+            logger.debug(f"Failed to verify JS requirements: {e}")
+
     def run_benchmarks(
         self, file_to_funcs_to_optimize: dict[Path, list[FunctionToOptimize]], num_optimizable_functions: int
     ) -> tuple[dict[str, dict[BenchmarkKey, float]], dict[BenchmarkKey, float]]:
@@ -466,6 +493,8 @@ def run(self) -> None:
                     # For JavaScript, also set js_project_root for test execution
                     if is_javascript():
                         self.test_cfg.js_project_root = self._find_js_project_root(file_path)
+                        # Verify JS requirements before proceeding
+                        self._verify_js_requirements()
                     break
 
         if self.args.all: