Merge pull request #1686 from codeflash-ai/trace_ops

perf: optimize tracer hot path with string-based path ops and caching

Author: KRRT7

codeflash/tracing/tracing_new_process.py

@@ -125,6 +125,7 @@ def __init__(
         self.max_function_count = max_function_count
         self.config = config
         self.project_root = project_root
+        self.project_root_str = str(project_root) + os.sep if project_root else ""
         console.rule(f"Project Root: {self.project_root}", style="bold blue")
         self.ignored_functions = {"<listcomp>", "<genexpr>", "<dictcomp>", "<setcomp>", "<lambda>", "<module>"}
 
@@ -327,19 +328,20 @@ def tracer_logic(self, frame: FrameType, event: str) -> None:
         if code.co_name in self.ignored_functions:
             return
 
-        # Now resolve file path only if we need it
+        # Resolve file path and check validity (cached)
         co_filename = code.co_filename
         if co_filename in self.path_cache:
-            file_name = self.path_cache[co_filename]
+            file_name, is_valid = self.path_cache[co_filename]
+            if not is_valid:
+                return
         else:
-            file_name = Path(co_filename).resolve()
-            self.path_cache[co_filename] = file_name
-        # TODO : It currently doesn't log the last return call from the first function
-
-        if not file_name.is_relative_to(self.project_root):
-            return
-        if not file_name.exists():
-            return
+            resolved = os.path.realpath(co_filename)
+            # startswith is cheaper than Path.is_relative_to, os.path.exists avoids Path construction
+            is_valid = resolved.startswith(self.project_root_str) and os.path.exists(resolved)  # noqa: PTH110
+            self.path_cache[co_filename] = (resolved, is_valid)
+            if not is_valid:
+                return
+            file_name = resolved
         if self.functions and code.co_name not in self.functions:
             return
         class_name = None
@@ -376,10 +378,11 @@ def tracer_logic(self, frame: FrameType, event: str) -> None:
         if function_qualified_name in self.ignored_qualified_functions:
             return
         if function_qualified_name not in self.function_count:
-            # seeing this function for the first time
+            # seeing this function for the first time — Path construction only happens here
             self.function_count[function_qualified_name] = 1
+            file_path = Path(file_name)
             file_valid = filter_files_optimized(
-                file_path=file_name,
+                file_path=file_path,
                 tests_root=Path(self.config["tests_root"]),
                 ignore_paths=[Path(p) for p in self.config["ignore_paths"]],
                 module_root=Path(self.config["module_root"]),
@@ -391,8 +394,8 @@ def tracer_logic(self, frame: FrameType, event: str) -> None:
             self.function_modules.append(
                 FunctionModules(
                     function_name=code.co_name,
-                    file_name=file_name,
-                    module_name=module_name_from_file_path(file_name, project_root_path=self.project_root),
+                    file_name=file_path,
+                    module_name=module_name_from_file_path(file_path, project_root_path=self.project_root),
                     class_name=class_name,
                     line_no=code.co_firstlineno,
                 )
@@ -432,16 +435,7 @@ def tracer_logic(self, frame: FrameType, event: str) -> None:
 
             cur.execute(
                 "INSERT INTO function_calls VALUES(?, ?, ?, ?, ?, ?, ?, ?)",
-                (
-                    event,
-                    code.co_name,
-                    class_name,
-                    str(file_name),
-                    frame.f_lineno,
-                    frame.f_back.__hash__(),
-                    t_ns,
-                    local_vars,
-                ),
+                (event, code.co_name, class_name, file_name, frame.f_lineno, frame.f_back.__hash__(), t_ns, local_vars),
             )
             self.trace_count += 1
             self.next_insert -= 1

pyproject.toml

@@ -344,7 +344,7 @@ __version__ = "{version}"
 [tool.codeflash]
 # All paths are relative to this pyproject.toml's directory.
 module-root = "codeflash"
-tests-root = "codeflash"
+tests-root = "tests"
 benchmarks-root = "tests/benchmarks"
 ignore-paths = []
 formatter-cmds = ["disabled"]

tests/test_worktree.py

@@ -61,9 +61,9 @@ def test_mirror_paths_for_worktree_mode(monkeypatch: pytest.MonkeyPatch):
     assert optimizer.args.test_project_root == worktree_dir
     assert optimizer.args.module_root == worktree_dir / "codeflash"
     # tests_root is configured as "codeflash" in pyproject.toml
-    assert optimizer.args.tests_root == worktree_dir / "codeflash"
+    assert optimizer.args.tests_root == worktree_dir / "tests"
     assert optimizer.args.file == worktree_dir / "codeflash/optimization/optimizer.py"
 
-    assert optimizer.test_cfg.tests_root == worktree_dir / "codeflash"
+    assert optimizer.test_cfg.tests_root == worktree_dir / "tests"
     assert optimizer.test_cfg.project_root_path == worktree_dir  # same as project_root
     assert optimizer.test_cfg.tests_project_rootdir == worktree_dir  # same as test_project_root