small fixes

Author: mohammedahmed18

codeflash/languages/javascript/support.py

@@ -1963,6 +1963,8 @@ def setup_test_config(self, test_cfg: TestConfig, file_path: Path, current_workt
         from codeflash.languages.javascript.test_runner import find_node_project_root
 
         test_cfg.js_project_root = find_node_project_root(file_path)
+        if test_cfg.js_project_root is None:
+            return False
         if current_worktree is not None:
             original_js_root = git_root_dir()
             worktree_node_modules = test_cfg.js_project_root / "node_modules"
@@ -2248,7 +2250,7 @@ def verify_requirements(self, project_root: Path, test_framework: str = "jest")
             Tuple of (success, list of error messages).
 
         """
-        errors: list[str] = []
+        errors: list[SetupError] = []
 
         # Check Node.js
         try:

tests/test_languages/test_javascript_requirements.py

@@ -177,6 +177,44 @@ def test_verify_requirements_jest_not_installed(self, js_support, project_with_v
             assert errors[0].message == expected_message
 
 
+class TestSetupTestConfig:
+    """Tests for JavaScriptSupport.setup_test_config() early-exit behavior."""
+
+    @pytest.fixture
+    def js_support(self):
+        return JavaScriptSupport()
+
+    def test_setup_test_config_returns_false_on_abort_error(self, js_support, tmp_path):
+        """setup_test_config returns False when verify_js_requirements reports a should_abort error."""
+        from codeflash.languages.base import SetupError
+
+        abort_error = SetupError("Node.js is not installed", should_abort=True)
+        with (
+            patch("codeflash.languages.javascript.test_runner.find_node_project_root", return_value=tmp_path.resolve()),
+            patch("codeflash.languages.javascript.optimizer.verify_js_requirements", return_value=[abort_error]),
+        ):
+            test_cfg = MagicMock()
+            result = js_support.setup_test_config(test_cfg, tmp_path.resolve(), current_worktree=None)
+            assert result is False
+
+    def test_setup_test_config_returns_true_on_no_errors(self, js_support, tmp_path):
+        """setup_test_config returns True when verify_js_requirements reports no errors."""
+        with (
+            patch("codeflash.languages.javascript.test_runner.find_node_project_root", return_value=tmp_path.resolve()),
+            patch("codeflash.languages.javascript.optimizer.verify_js_requirements", return_value=[]),
+        ):
+            test_cfg = MagicMock()
+            result = js_support.setup_test_config(test_cfg, tmp_path.resolve(), current_worktree=None)
+            assert result is True
+
+    def test_setup_test_config_returns_false_when_project_root_is_none(self, js_support, tmp_path):
+        """setup_test_config returns False when find_node_project_root returns None."""
+        with patch("codeflash.languages.javascript.test_runner.find_node_project_root", return_value=None):
+            test_cfg = MagicMock()
+            result = js_support.setup_test_config(test_cfg, tmp_path.resolve(), current_worktree=None)
+            assert result is False
+
+
 class TestVerifyRequirementsIntegration:
     """Integration tests for verify_requirements with real filesystem."""