|
| 1 | +from __future__ import annotations |
| 2 | + |
| 3 | +from pathlib import Path |
| 4 | +from unittest.mock import patch |
| 5 | + |
| 6 | +from codeflash.discovery.functions_to_optimize import ( |
| 7 | + get_all_files_and_functions, |
| 8 | + get_functions_within_lines, |
| 9 | +) |
| 10 | + |
| 11 | + |
| 12 | +def test_prefilter_skips_test_files(tmp_path: Path) -> None: |
| 13 | + """Files in tests_root should be skipped before read_text() is called.""" |
| 14 | + module_root = tmp_path / "src" |
| 15 | + module_root.mkdir() |
| 16 | + tests_root = tmp_path / "tests" |
| 17 | + tests_root.mkdir() |
| 18 | + |
| 19 | + source_file = module_root / "app.py" |
| 20 | + source_file.write_text("def compute():\n return 1\n", encoding="utf-8") |
| 21 | + |
| 22 | + test_file = tests_root / "test_app.py" |
| 23 | + test_file.write_text("def test_compute():\n return True\n", encoding="utf-8") |
| 24 | + |
| 25 | + with patch("codeflash.discovery.functions_to_optimize.get_files_for_language") as mock_get_files: |
| 26 | + mock_get_files.return_value = [source_file, test_file] |
| 27 | + result = get_all_files_and_functions( |
| 28 | + module_root, ignore_paths=[], tests_root=tests_root, module_root=module_root |
| 29 | + ) |
| 30 | + |
| 31 | + assert source_file in result |
| 32 | + assert test_file not in result |
| 33 | + |
| 34 | + |
| 35 | +def test_prefilter_skips_ignored_paths(tmp_path: Path) -> None: |
| 36 | + """Files in ignore_paths should be skipped before read_text() is called.""" |
| 37 | + module_root = tmp_path / "src" |
| 38 | + module_root.mkdir() |
| 39 | + tests_root = tmp_path / "tests" |
| 40 | + tests_root.mkdir() |
| 41 | + ignored_dir = module_root / "vendor" |
| 42 | + ignored_dir.mkdir() |
| 43 | + |
| 44 | + source_file = module_root / "app.py" |
| 45 | + source_file.write_text("def compute():\n return 1\n", encoding="utf-8") |
| 46 | + |
| 47 | + vendor_file = ignored_dir / "lib.py" |
| 48 | + vendor_file.write_text("def helper():\n return 2\n", encoding="utf-8") |
| 49 | + |
| 50 | + with patch("codeflash.discovery.functions_to_optimize.get_files_for_language") as mock_get_files: |
| 51 | + mock_get_files.return_value = [source_file, vendor_file] |
| 52 | + result = get_all_files_and_functions( |
| 53 | + module_root, ignore_paths=[ignored_dir], tests_root=tests_root, module_root=module_root |
| 54 | + ) |
| 55 | + |
| 56 | + assert source_file in result |
| 57 | + assert vendor_file not in result |
| 58 | + |
| 59 | + |
| 60 | +def test_prefilter_skips_files_outside_module_root(tmp_path: Path) -> None: |
| 61 | + """Files outside module_root should be skipped before read_text() is called.""" |
| 62 | + module_root = tmp_path / "src" |
| 63 | + module_root.mkdir() |
| 64 | + tests_root = tmp_path / "tests" |
| 65 | + tests_root.mkdir() |
| 66 | + other_dir = tmp_path / "other" |
| 67 | + other_dir.mkdir() |
| 68 | + |
| 69 | + source_file = module_root / "app.py" |
| 70 | + source_file.write_text("def compute():\n return 1\n", encoding="utf-8") |
| 71 | + |
| 72 | + outside_file = other_dir / "stray.py" |
| 73 | + outside_file.write_text("def stray():\n return 3\n", encoding="utf-8") |
| 74 | + |
| 75 | + with patch("codeflash.discovery.functions_to_optimize.get_files_for_language") as mock_get_files: |
| 76 | + mock_get_files.return_value = [source_file, outside_file] |
| 77 | + result = get_all_files_and_functions( |
| 78 | + module_root, ignore_paths=[], tests_root=tests_root, module_root=module_root |
| 79 | + ) |
| 80 | + |
| 81 | + assert source_file in result |
| 82 | + assert outside_file not in result |
| 83 | + |
| 84 | + |
| 85 | +def test_prefilter_disabled_without_params(tmp_path: Path) -> None: |
| 86 | + """Without tests_root/module_root, no prefiltering occurs (backward compat).""" |
| 87 | + module_root = tmp_path / "src" |
| 88 | + module_root.mkdir() |
| 89 | + |
| 90 | + source_file = module_root / "app.py" |
| 91 | + source_file.write_text("def compute():\n return 1\n", encoding="utf-8") |
| 92 | + |
| 93 | + with patch("codeflash.discovery.functions_to_optimize.get_files_for_language") as mock_get_files: |
| 94 | + mock_get_files.return_value = [source_file] |
| 95 | + result = get_all_files_and_functions(module_root, ignore_paths=[]) |
| 96 | + |
| 97 | + assert source_file in result |
| 98 | + |
| 99 | + |
| 100 | +def test_prefilter_in_get_functions_within_lines(tmp_path: Path) -> None: |
| 101 | + """get_functions_within_lines should skip test files when prefilter params are provided.""" |
| 102 | + module_root = tmp_path / "src" |
| 103 | + module_root.mkdir() |
| 104 | + tests_root = tmp_path / "tests" |
| 105 | + tests_root.mkdir() |
| 106 | + |
| 107 | + source_file = module_root / "app.py" |
| 108 | + source_file.write_text("def compute():\n return 1\n", encoding="utf-8") |
| 109 | + |
| 110 | + test_file = tests_root / "test_app.py" |
| 111 | + test_file.write_text("def test_compute():\n return True\n", encoding="utf-8") |
| 112 | + |
| 113 | + modified_lines = { |
| 114 | + str(source_file): [1, 2], |
| 115 | + str(test_file): [1, 2], |
| 116 | + } |
| 117 | + |
| 118 | + result = get_functions_within_lines( |
| 119 | + modified_lines, tests_root=tests_root, ignore_paths=[], module_root=module_root |
| 120 | + ) |
| 121 | + |
| 122 | + assert source_file in result |
| 123 | + assert test_file not in result |
| 124 | + |
| 125 | + |
| 126 | +def test_prefilter_avoids_reading_skipped_files(tmp_path: Path) -> None: |
| 127 | + """Verify that find_all_functions_in_file is NOT called for prefiltered files (the core perf win).""" |
| 128 | + module_root = tmp_path / "src" |
| 129 | + module_root.mkdir() |
| 130 | + tests_root = tmp_path / "tests" |
| 131 | + tests_root.mkdir() |
| 132 | + |
| 133 | + source_file = module_root / "app.py" |
| 134 | + source_file.write_text("def compute():\n return 1\n", encoding="utf-8") |
| 135 | + |
| 136 | + test_file = tests_root / "test_app.py" |
| 137 | + test_file.write_text("def test_compute():\n return True\n", encoding="utf-8") |
| 138 | + |
| 139 | + with ( |
| 140 | + patch("codeflash.discovery.functions_to_optimize.get_files_for_language") as mock_get_files, |
| 141 | + patch("codeflash.discovery.functions_to_optimize.find_all_functions_in_file") as mock_find, |
| 142 | + ): |
| 143 | + mock_get_files.return_value = [source_file, test_file] |
| 144 | + mock_find.return_value = {} |
| 145 | + get_all_files_and_functions( |
| 146 | + module_root, ignore_paths=[], tests_root=tests_root, module_root=module_root |
| 147 | + ) |
| 148 | + |
| 149 | + # find_all_functions_in_file (which does read_text) should only be called for source_file |
| 150 | + assert mock_find.call_count == 1 |
| 151 | + mock_find.assert_called_once_with(source_file) |
| 152 | + |
| 153 | + |
| 154 | +def test_prefilter_skips_submodule_paths(tmp_path: Path) -> None: |
| 155 | + """Submodule paths should be skipped by prefilter.""" |
| 156 | + module_root = tmp_path / "src" |
| 157 | + module_root.mkdir() |
| 158 | + tests_root = tmp_path / "tests" |
| 159 | + tests_root.mkdir() |
| 160 | + submodule_dir = module_root / "vendor_submodule" |
| 161 | + submodule_dir.mkdir() |
| 162 | + |
| 163 | + source_file = module_root / "app.py" |
| 164 | + source_file.write_text("def compute():\n return 1\n", encoding="utf-8") |
| 165 | + |
| 166 | + submodule_file = submodule_dir / "lib.py" |
| 167 | + submodule_file.write_text("def helper():\n return 2\n", encoding="utf-8") |
| 168 | + |
| 169 | + with ( |
| 170 | + patch("codeflash.discovery.functions_to_optimize.get_files_for_language") as mock_get_files, |
| 171 | + patch( |
| 172 | + "codeflash.discovery.functions_to_optimize.ignored_submodule_paths", return_value=[submodule_dir] |
| 173 | + ), |
| 174 | + ): |
| 175 | + mock_get_files.return_value = [source_file, submodule_file] |
| 176 | + result = get_all_files_and_functions( |
| 177 | + module_root, ignore_paths=[], tests_root=tests_root, module_root=module_root |
| 178 | + ) |
| 179 | + |
| 180 | + assert source_file in result |
| 181 | + assert submodule_file not in result |
0 commit comments