Skip to content

Commit 7cd13a1

Browse files
committed
chore: remove linked-issue and gate CI jobs
1 parent d7f95a5 commit 7cd13a1

3 files changed

Lines changed: 0 additions & 93 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,3 @@
1-
## Linked issue or discussion
2-
3-
<!-- Every PR must link to an issue or discussion — this ensures the approach has been discussed with maintainers before implementation begins, so your work fits the project's direction and doesn't need to be reworked. -->
4-
<!-- Replace the line below with one of: -->
5-
<!-- Closes #<number> -->
6-
<!-- Fixes #<number> -->
7-
<!-- Relates to #<number> -->
8-
<!-- Discussion: <url> -->
9-
10-
**Required:** <!-- CI will fail if no linked issue or discussion is found. -->
11-
121
## What changed
132

143
<!-- Brief description of the changes. -->

.github/workflows/ci.yaml

Lines changed: 0 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -22,64 +22,6 @@ concurrency:
2222
cancel-in-progress: true
2323

2424
jobs:
25-
# ---------------------------------------------------------------------------
26-
# Linked issue check — every PR must reference an issue or discussion.
27-
# Skipped on push to main and workflow_dispatch.
28-
# ---------------------------------------------------------------------------
29-
check-linked-issue:
30-
if: github.event_name == 'pull_request'
31-
runs-on: ubuntu-latest
32-
permissions:
33-
pull-requests: read
34-
steps:
35-
- name: Check PR body for linked issue or discussion
36-
env:
37-
PR_BODY: ${{ github.event.pull_request.body }}
38-
PR_AUTHOR: ${{ github.event.pull_request.user.login }}
39-
AUTHOR_ASSOCIATION: ${{ github.event.pull_request.author_association }}
40-
run: |
41-
# Skip for bots (dependabot, renovate, github-actions)
42-
if [[ "$PR_AUTHOR" == *"[bot]"* || "$PR_AUTHOR" == "dependabot" ]]; then
43-
echo "Bot PR — skipping linked issue check."
44-
exit 0
45-
fi
46-
47-
# Skip for org members and collaborators
48-
if [[ "$AUTHOR_ASSOCIATION" == "MEMBER" || "$AUTHOR_ASSOCIATION" == "COLLABORATOR" || "$AUTHOR_ASSOCIATION" == "OWNER" ]]; then
49-
echo "Org member ($PR_AUTHOR, $AUTHOR_ASSOCIATION) — skipping linked issue check."
50-
exit 0
51-
fi
52-
53-
if [ -z "$PR_BODY" ]; then
54-
echo "::error::PR body is empty. Every PR must link an issue or discussion."
55-
echo "Use 'Closes #<number>', 'Fixes #<number>', 'Relates to #<number>', or include a discussion URL."
56-
exit 1
57-
fi
58-
59-
# Match: #123, GH-123, org/repo#123, Closes/Fixes/Relates/Resolves #123,
60-
# or a github.com URL to an issue or discussion
61-
if echo "$PR_BODY" | grep -qiP '(close[sd]?|fix(e[sd])?|relate[sd]?\s+to|resolve[sd]?)\s+#\d+'; then
62-
echo "Found linked issue keyword."
63-
exit 0
64-
fi
65-
if echo "$PR_BODY" | grep -qP '#\d+'; then
66-
echo "Found issue reference."
67-
exit 0
68-
fi
69-
if echo "$PR_BODY" | grep -qiP 'github\.com/[^\s]+/(issues|discussions)/\d+'; then
70-
echo "Found GitHub issue/discussion URL."
71-
exit 0
72-
fi
73-
if echo "$PR_BODY" | grep -qiP 'CF-#?\d+'; then
74-
echo "Found Linear ticket reference."
75-
exit 0
76-
fi
77-
78-
echo "::error::No linked issue or discussion found in PR body."
79-
echo "Every PR must reference an issue or discussion. See CONTRIBUTING.md for details."
80-
echo "Use 'Closes #<number>', 'Fixes #<number>', 'Relates to #<number>', or include a discussion URL."
81-
exit 1
82-
8325
# ---------------------------------------------------------------------------
8426
# Change detection — decides which downstream jobs actually run.
8527
# On push/workflow_dispatch every flag is true so all jobs execute.
@@ -512,26 +454,3 @@ jobs:
512454
513455
- name: Run E2E test
514456
run: uv run python tests/scripts/${{ matrix.script }}
515-
516-
# ---------------------------------------------------------------------------
517-
# Gate job — the ONLY required check in the GitHub ruleset.
518-
# Accepts "success" and "skipped" (job skipped by change detection).
519-
# Rejects "failure" and "cancelled".
520-
# ---------------------------------------------------------------------------
521-
required-checks-passed:
522-
name: required checks passed
523-
if: always()
524-
needs:
525-
- check-linked-issue
526-
- unit-tests
527-
- coverage
528-
- type-check
529-
- prek
530-
- e2e-python
531-
- e2e-js
532-
- e2e-java
533-
runs-on: ubuntu-latest
534-
steps:
535-
- uses: codeflash-ai/github-workflows/.github/actions/required-checks-gate@main
536-
with:
537-
needs-json: ${{ toJSON(needs) }}

CONTRIBUTING.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ The full ruleset is in [`.claude/rules/code-style.md`](.claude/rules/code-style.
101101

102102
## Branches, commits, and pull requests
103103

104-
- **Every PR must link an issue or discussion.** Use `Closes #<number>`, `Fixes #<number>`, or `Relates to #<number>` in the PR body. CI will fail if no linked issue or discussion is found. For trivial fixes (typos, formatting), open a lightweight issue first — it only takes a moment and keeps the history traceable. The goal is to have a conversation before the code — discussing the approach on an issue or discussion helps maintainers point you in the right direction early, so your implementation fits the project's needs and you don't spend time on work that gets reworked.
105104
- Create a feature branch off an up-to-date `main`. Never commit directly to `main`.
106105
- Use conventional-commit prefixes: `fix:`, `feat:`, `refactor:`, `docs:`, `test:`, `chore:`. Keep commit messages concise (1-2 sentence body max).
107106
- Keep commits atomic - one logical change per commit.

0 commit comments

Comments
 (0)