Skip to content

Commit 82ec301

Browse files
committed
chore: remove diagnostic logging from compare_test_results
1 parent 986654b commit 82ec301

1 file changed

Lines changed: 7 additions & 46 deletions

File tree

codeflash/verification/equivalence.py

Lines changed: 7 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -41,33 +41,23 @@ def compare_test_results(
4141
)
4242
test_diffs: list[TestDiff] = []
4343
did_all_timeout: bool = True
44-
_matched_count = 0
45-
_skipped_cdd_only = 0
46-
_skipped_init_state = 0
47-
_skipped_none = 0
48-
_timed_out_count = 0
4944
for test_id in test_ids_superset:
5045
original_test_result = original_results.get_by_unique_invocation_loop_id(test_id)
5146
cdd_test_result = candidate_results.get_by_unique_invocation_loop_id(test_id)
5247

5348
if cdd_test_result is not None and original_test_result is None:
54-
_skipped_cdd_only += 1
5549
continue
5650
# If helper function instance_state verification is not present, that's ok. continue
5751
if (
5852
original_test_result.verification_type
5953
and original_test_result.verification_type == VerificationType.INIT_STATE_HELPER
6054
and cdd_test_result is None
6155
):
62-
_skipped_init_state += 1
6356
continue
6457
if original_test_result is None or cdd_test_result is None:
65-
_skipped_none += 1
6658
continue
67-
_matched_count += 1
6859
did_all_timeout = did_all_timeout and original_test_result.timed_out
6960
if original_test_result.timed_out:
70-
_timed_out_count += 1
7161
continue
7262
superset_obj = False
7363
if original_test_result.verification_type and (
@@ -111,11 +101,6 @@ def compare_test_results(
111101
original_pytest_error=original_pytest_error,
112102
)
113103
)
114-
logger.info(
115-
f"[DIFF] scope=DID_PASS test_id={test_id} "
116-
f"orig_pass={original_test_result.did_pass} cand_pass={cdd_test_result.did_pass} "
117-
f"test_type={original_test_result.test_type} cand_error={cdd_pytest_error[:200] if cdd_pytest_error else 'none'}"
118-
)
119104

120105
elif not pass_fail_only and not comparator(
121106
original_test_result.return_value, cdd_test_result.return_value, superset_obj=superset_obj
@@ -134,15 +119,13 @@ def compare_test_results(
134119
)
135120

136121
try:
137-
_orig_rv = original_test_result.return_value
138-
_cand_rv = cdd_test_result.return_value
139-
logger.info(
140-
f"[DIFF] scope=RETURN_VALUE test_id={test_id} "
141-
f"orig_type={type(_orig_rv).__name__} cand_type={type(_cand_rv).__name__} "
142-
f"orig_pass={original_test_result.did_pass} cand_pass={cdd_test_result.did_pass} "
143-
f"test_type={original_test_result.test_type} "
144-
f"orig_repr={safe_repr(_orig_rv)[:200]} "
145-
f"cand_repr={safe_repr(_cand_rv)[:200]}"
122+
logger.debug(
123+
f"File Name: {original_test_result.file_name}\n"
124+
f"Test Type: {original_test_result.test_type}\n"
125+
f"Verification Type: {original_test_result.verification_type}\n"
126+
f"Invocation ID: {original_test_result.id}\n"
127+
f"Original return value: {original_test_result.return_value}\n"
128+
f"Candidate return value: {cdd_test_result.return_value}\n"
146129
)
147130
except Exception as e:
148131
logger.error(e)
@@ -163,30 +146,8 @@ def compare_test_results(
163146
original_pytest_error=original_pytest_error,
164147
)
165148
)
166-
logger.info(
167-
f"[DIFF] scope=STDOUT test_id={test_id} "
168-
f"orig_stdout={str(original_test_result.stdout)[:200]} "
169-
f"cand_stdout={str(cdd_test_result.stdout)[:200]}"
170-
)
171149

172150
sys.setrecursionlimit(original_recursion_limit)
173-
logger.info(
174-
f"[compare_test_results] superset={len(test_ids_superset)} matched={_matched_count} "
175-
f"skipped(cdd_only={_skipped_cdd_only} init_state={_skipped_init_state} none={_skipped_none}) "
176-
f"timed_out={_timed_out_count} did_all_timeout={did_all_timeout} diffs={len(test_diffs)} "
177-
f"pass_fail_only={pass_fail_only} orig_len={len(original_results)} cand_len={len(candidate_results)}"
178-
)
179-
if did_all_timeout and _matched_count > 0 and _matched_count <= 3:
180-
# Log a few sample matched IDs for debugging
181-
_sample_ids = []
182-
for test_id in test_ids_superset:
183-
orig = original_results.get_by_unique_invocation_loop_id(test_id)
184-
cand = candidate_results.get_by_unique_invocation_loop_id(test_id)
185-
if orig is not None and cand is not None:
186-
_sample_ids.append(f" id={test_id} orig_timed_out={orig.timed_out} orig_pass={orig.did_pass}")
187-
if len(_sample_ids) >= 3:
188-
break
189-
logger.info(f"[compare_test_results] sample matched: {_sample_ids}")
190151
if did_all_timeout:
191152
return False, test_diffs
192153
return len(test_diffs) == 0, test_diffs

0 commit comments

Comments
 (0)