Skip to content

Commit 8959ead

Browse files
committed
fix: resolve Windows 8.3 short paths in get_run_tmp_file and fix ruff lint errors
Add .resolve() to TemporaryDirectory path to expand Windows 8.3 short paths (e.g. RUNNER~1) to canonical long form, fixing test_pickle_patcher failures on Windows CI. Also add missing return type annotations and noqa suppressions for benchmark test file.
1 parent ec14860 commit 8959ead

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

.codeflash/benchmarks/test_benchmark_merge_test_results.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from codeflash.verification.parse_test_output import merge_test_results
33

44

5-
def generate_test_invocations(count=100):
5+
def generate_test_invocations(count: int = 100) -> tuple[TestResults, TestResults]:
66
"""Generate a set number of test invocations for benchmarking."""
77
test_results_xml = TestResults()
88
test_results_bin = TestResults()
@@ -21,7 +21,7 @@ def generate_test_invocations(count=100):
2121
function_getting_tested="sorter",
2222
iteration_id=iteration_id,
2323
),
24-
file_name="/tmp/tests/unittest/test_bubble_sort__perfinstrumented.py",
24+
file_name="/tmp/tests/unittest/test_bubble_sort__perfinstrumented.py", # noqa: S108
2525
did_pass=True,
2626
runtime=None if i % 3 == 0 else i * 100, # Vary runtime values
2727
test_framework="unittest",
@@ -42,7 +42,7 @@ def generate_test_invocations(count=100):
4242
function_getting_tested="sorter",
4343
iteration_id=iteration_id,
4444
),
45-
file_name="/tmp/tests/unittest/test_bubble_sort__perfinstrumented.py",
45+
file_name="/tmp/tests/unittest/test_bubble_sort__perfinstrumented.py", # noqa: S108
4646
did_pass=True,
4747
runtime=500 + i * 20, # Generate varying runtime values
4848
test_framework="unittest",
@@ -56,12 +56,12 @@ def generate_test_invocations(count=100):
5656
return test_results_xml, test_results_bin
5757

5858

59-
def run_merge_benchmark(count=100):
59+
def run_merge_benchmark(count: int = 100) -> None:
6060
test_results_xml, test_results_bin = generate_test_invocations(count)
6161

6262
# Perform the merge operation that will be benchmarked
6363
merge_test_results(xml_test_results=test_results_xml, bin_test_results=test_results_bin, test_framework="unittest")
6464

6565

66-
def test_benchmark_merge_test_results(benchmark):
66+
def test_benchmark_merge_test_results(benchmark) -> None:
6767
benchmark(run_merge_benchmark, 1000) # Default to 100 test invocations

codeflash/code_utils/code_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ def get_run_tmp_file(file_path: Path | str) -> Path:
423423
file_path = Path(file_path)
424424
if not hasattr(get_run_tmp_file, "tmpdir_path"):
425425
get_run_tmp_file.tmpdir = TemporaryDirectory(prefix="codeflash_")
426-
get_run_tmp_file.tmpdir_path = Path(get_run_tmp_file.tmpdir.name)
426+
get_run_tmp_file.tmpdir_path = Path(get_run_tmp_file.tmpdir.name).resolve()
427427
return get_run_tmp_file.tmpdir_path / file_path
428428

429429

0 commit comments

Comments
 (0)