style: fix linting issues in vitest setupFiles PR

- Move `import re` to module-level (was inside function body)
- Add encoding="utf-8" to read_text() call
- Fix tests: use tmp_path fixture, add -> None return types, add encoding args

Co-authored-by: mohammed ahmed <undefined@users.noreply.github.com>

Author: github-actions[bot]

codeflash/languages/javascript/vitest_runner.py

@@ -7,6 +7,7 @@
 from __future__ import annotations
 
 import os
+import re
 import subprocess
 import time
 from pathlib import Path
@@ -169,18 +170,17 @@ def _is_vitest_workspace(project_root: Path) -> bool:
         return False
 
     try:
-        content = vitest_config.read_text()
+        content = vitest_config.read_text(encoding="utf-8")
         # Check for actual workspace configuration patterns (not just the word "workspace" in comments)
         # Valid indicators:
         #   - defineWorkspace() function call
         #   - workspace: [ array config
         #   - separate vitest.workspace.ts/js file
-        import re
         # Match defineWorkspace calls or workspace: property assignments
         workspace_pattern = re.compile(
-            r'(?:^|[^a-zA-Z_])defineWorkspace\s*\(|'  # defineWorkspace( function call
-            r'(?:^|[^a-zA-Z_])workspace\s*:\s*\[',     # workspace: [ array
-            re.MULTILINE
+            r"(?:^|[^a-zA-Z_])defineWorkspace\s*\(|"  # defineWorkspace( function call
+            r"(?:^|[^a-zA-Z_])workspace\s*:\s*\[",  # workspace: [ array
+            re.MULTILINE,
         )
         if workspace_pattern.search(content):
             return True

tests/languages/javascript/test_vitest_setupfiles_fix.py

@@ -1,34 +1,18 @@
-"""Test that Codeflash Vitest config properly handles setupFiles from project config.
-
-This test verifies that when creating a custom Vitest config, setupFiles paths
-are converted to absolute paths or cleared to prevent resolution issues in nested directories.
-"""
-
 from pathlib import Path
-import tempfile
-import pytest
-
 
-def test_codeflash_vitest_config_overrides_setupfiles():
-    """Test that generated config overrides setupFiles to prevent path resolution issues.
+import pytest
 
-    When a project has setupFiles with relative paths, and Codeflash generates tests
-    for functions in nested directories, those relative paths will resolve incorrectly.
+from codeflash.languages.javascript.vitest_runner import _ensure_codeflash_vitest_config
 
-    The fix: Convert setupFiles paths to absolute, or disable them for generated tests.
-    """
-    from codeflash.languages.javascript.vitest_runner import _ensure_codeflash_vitest_config
 
-    with tempfile.TemporaryDirectory() as tmpdir:
-        project_root = Path(tmpdir)
+def test_codeflash_vitest_config_overrides_setupfiles(tmp_path: Path) -> None:
+    project_root = tmp_path.resolve()
 
-        # Create a project with setup file
-        (project_root / "test").mkdir()
-        setup_file = project_root / "test" / "setup.ts"
-        setup_file.write_text("// Setup file\n")
+    # Create a project with setup file
+    (project_root / "test").mkdir()
+    (project_root / "test" / "setup.ts").write_text("// Setup file\n", encoding="utf-8")
 
-        # Create vitest config with relative setupFiles path
-        vitest_config = """import { defineConfig } from 'vitest/config';
+    vitest_config = """import { defineConfig } from 'vitest/config';
 
 export default defineConfig({
   test: {
@@ -37,61 +21,41 @@ def test_codeflash_vitest_config_overrides_setupfiles():
   },
 });
 """
-        (project_root / "vitest.config.ts").write_text(vitest_config)
-
-        # Call the function to create Codeflash config
-        codeflash_config_path = _ensure_codeflash_vitest_config(project_root)
-
-        # Verify the config was created
-        assert codeflash_config_path is not None
-        assert codeflash_config_path.exists()
-
-        # Read the generated config
-        config_content = codeflash_config_path.read_text()
+    (project_root / "vitest.config.ts").write_text(vitest_config, encoding="utf-8")
 
-        # The config should either:
-        # 1. Set setupFiles to an empty array (disable setup files for generated tests)
-        # 2. OR convert the path to absolute using project root resolution
+    codeflash_config_path = _ensure_codeflash_vitest_config(project_root)
 
-        # Check that setupFiles is mentioned and handled in the merge
-        assert "setupFiles" in config_content, (
-            "Generated config must explicitly handle setupFiles to prevent "
-            "relative path resolution issues. Current config:\n" + config_content
-        )
+    assert codeflash_config_path is not None
+    assert codeflash_config_path.exists()
 
-        # The config should set setupFiles to [] or to absolute paths
-        # This prevents the relative path from being resolved incorrectly
-        assert ("setupFiles: []" in config_content or
-                "setupFiles:" in config_content), (
-            "setupFiles must be explicitly set in the merged config"
-        )
+    config_content = codeflash_config_path.read_text(encoding="utf-8")
 
+    assert "setupFiles" in config_content, (
+        "Generated config must explicitly handle setupFiles to prevent "
+        "relative path resolution issues. Current config:\n" + config_content
+    )
+    assert "setupFiles: []" in config_content or "setupFiles:" in config_content, (
+        "setupFiles must be explicitly set in the merged config"
+    )
 
-def test_codeflash_vitest_config_without_setupfiles():
-    """Test that configs without setupFiles still work correctly."""
-    from codeflash.languages.javascript.vitest_runner import _ensure_codeflash_vitest_config
 
-    with tempfile.TemporaryDirectory() as tmpdir:
-        project_root = Path(tmpdir)
+def test_codeflash_vitest_config_without_setupfiles(tmp_path: Path) -> None:
+    project_root = tmp_path.resolve()
 
-        # Create vitest config WITHOUT setupFiles
-        vitest_config = """import { defineConfig } from 'vitest/config';
+    vitest_config = """import { defineConfig } from 'vitest/config';
 
 export default defineConfig({
   test: {
     include: ["src/**/*.test.ts"],
   },
 });
 """
-        (project_root / "vitest.config.ts").write_text(vitest_config)
+    (project_root / "vitest.config.ts").write_text(vitest_config, encoding="utf-8")
 
-        # Call the function to create Codeflash config
-        codeflash_config_path = _ensure_codeflash_vitest_config(project_root)
+    codeflash_config_path = _ensure_codeflash_vitest_config(project_root)
 
-        # Verify the config was created
-        assert codeflash_config_path is not None
-        assert codeflash_config_path.exists()
+    assert codeflash_config_path is not None
+    assert codeflash_config_path.exists()
 
-        # Config should be created successfully
-        config_content = codeflash_config_path.read_text()
-        assert "mergeConfig" in config_content or "defineConfig" in config_content
+    config_content = codeflash_config_path.read_text(encoding="utf-8")
+    assert "mergeConfig" in config_content or "defineConfig" in config_content