test: update Jest roots tests to verify runtime config behavior

Update TestJestRootsConfiguration to match the new runtime config
approach: verify no --roots/config when tests are inside the project
root, and verify runtime config creation when tests are outside it.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: mohammedahmed18

tests/test_languages/test_javascript_test_runner.py

@@ -8,28 +8,23 @@
 
 
 class TestJestRootsConfiguration:
-    """Tests for Jest --roots flag handling."""
+    """Tests for Jest runtime config creation when test files are outside the project root."""
 
-    def test_behavioral_tests_adds_roots_for_test_directories(self):
-        """Test that run_jest_behavioral_tests adds --roots for test directories."""
-        from codeflash.languages.javascript.test_runner import run_jest_behavioral_tests
+    def test_no_runtime_config_when_tests_inside_project_root(self):
+        """Test that no runtime config is created when test files are inside the project root."""
+        from codeflash.languages.javascript.test_runner import clear_created_config_files, get_created_config_files, run_jest_behavioral_tests
         from codeflash.models.models import TestFile, TestFiles
         from codeflash.models.test_type import TestType
 
-        # Create mock test files in a test directory
         with tempfile.TemporaryDirectory() as tmpdir:
             tmpdir_path = Path(tmpdir).resolve()
             test_dir = tmpdir_path / "test"
             test_dir.mkdir()
 
-            # Create package.json to simulate a Node project
             (tmpdir_path / "package.json").write_text('{"name": "test"}')
 
-            # Create mock test files
             test_file1 = test_dir / "test_func__unit_test_0.test.ts"
-            test_file2 = test_dir / "test_func__unit_test_1.test.ts"
             test_file1.write_text("// test 1")
-            test_file2.write_text("// test 2")
 
             mock_test_files = TestFiles(
                 test_files=[
@@ -39,16 +34,11 @@ def test_behavioral_tests_adds_roots_for_test_directories(self):
                         benchmarking_file_path=test_file1,
                         test_type=TestType.GENERATED_REGRESSION,
                     ),
-                    TestFile(
-                        original_file_path=test_file2,
-                        instrumented_behavior_file_path=test_file2,
-                        benchmarking_file_path=test_file2,
-                        test_type=TestType.GENERATED_REGRESSION,
-                    ),
                 ]
             )
 
-            # Mock subprocess.run to capture the command
+            clear_created_config_files()
+
             with patch("subprocess.run") as mock_run:
                 mock_result = MagicMock()
                 mock_result.stdout = ""
@@ -64,40 +54,32 @@ def test_behavioral_tests_adds_roots_for_test_directories(self):
                         project_root=tmpdir_path,
                     )
                 except Exception:
-                    pass  # Expected to fail since no real Jest
+                    pass
 
-                # Verify the command included --roots
                 if mock_run.called:
-                    call_args = mock_run.call_args
-                    cmd = call_args[0][0]
-
-                    # Find --roots flags in the command
-                    roots_flags = []
-                    for i, arg in enumerate(cmd):
-                        if arg == "--roots" and i + 1 < len(cmd):
-                            roots_flags.append(cmd[i + 1])
-
-                    # Should have added the test directory as a root
-                    assert len(roots_flags) > 0, "Expected --roots flag in Jest command"
-                    assert str(test_dir) in roots_flags or any(
-                        str(test_dir) in root for root in roots_flags
-                    ), f"Expected test directory {test_dir} in --roots flags: {roots_flags}"
-
-    def test_benchmarking_tests_adds_roots_for_test_directories(self):
-        """Test that run_jest_benchmarking_tests adds --roots for test directories."""
-        from codeflash.languages.javascript.test_runner import run_jest_benchmarking_tests
+                    cmd = mock_run.call_args[0][0]
+                    # No --roots flags should be present
+                    assert "--roots" not in cmd, "Should not have --roots flags when tests are inside project root"
+                    # No runtime config should have been created
+                    runtime_configs = [f for f in get_created_config_files() if "codeflash.runtime" in f.name]
+                    assert len(runtime_configs) == 0, "Should not create runtime config when tests are inside project root"
+
+            clear_created_config_files()
+
+    def test_behavioral_tests_creates_runtime_config_for_external_tests(self):
+        """Test that run_jest_behavioral_tests creates a runtime config when tests are outside the project root."""
+        from codeflash.languages.javascript.test_runner import clear_created_config_files, get_created_config_files, run_jest_behavioral_tests
         from codeflash.models.models import TestFile, TestFiles
         from codeflash.models.test_type import TestType
 
-        with tempfile.TemporaryDirectory() as tmpdir:
-            tmpdir_path = Path(tmpdir).resolve()
-            test_dir = tmpdir_path / "test"
-            test_dir.mkdir()
+        with tempfile.TemporaryDirectory() as project_dir, tempfile.TemporaryDirectory() as external_dir:
+            project_path = Path(project_dir).resolve()
+            external_path = Path(external_dir).resolve()
 
-            (tmpdir_path / "package.json").write_text('{"name": "test"}')
+            (project_path / "package.json").write_text('{"name": "test"}')
 
-            test_file = test_dir / "test_func__perf_test_0.test.ts"
-            test_file.write_text("// perf test")
+            test_file = external_path / "test_func__unit_test_0.test.ts"
+            test_file.write_text("// test 1")
 
             mock_test_files = TestFiles(
                 test_files=[
@@ -110,6 +92,8 @@ def test_benchmarking_tests_adds_roots_for_test_directories(self):
                 ]
             )
 
+            clear_created_config_files()
+
             with patch("subprocess.run") as mock_run:
                 mock_result = MagicMock()
                 mock_result.stdout = ""
@@ -118,41 +102,43 @@ def test_benchmarking_tests_adds_roots_for_test_directories(self):
                 mock_run.return_value = mock_result
 
                 try:
-                    run_jest_benchmarking_tests(
+                    run_jest_behavioral_tests(
                         test_paths=mock_test_files,
                         test_env={},
-                        cwd=tmpdir_path,
-                        project_root=tmpdir_path,
+                        cwd=project_path,
+                        project_root=project_path,
                     )
                 except Exception:
                     pass
 
                 if mock_run.called:
-                    call_args = mock_run.call_args
-                    cmd = call_args[0][0]
+                    cmd = mock_run.call_args[0][0]
+                    config_args = [arg for arg in cmd if arg.startswith("--config=")]
+                    assert any("codeflash.runtime" in arg for arg in config_args), (
+                        f"Expected runtime config in --config flag, got: {config_args}"
+                    )
 
-                    roots_flags = []
-                    for i, arg in enumerate(cmd):
-                        if arg == "--roots" and i + 1 < len(cmd):
-                            roots_flags.append(cmd[i + 1])
+                runtime_configs = [f for f in get_created_config_files() if "codeflash.runtime" in f.name]
+                assert len(runtime_configs) == 1, f"Expected 1 runtime config, got {len(runtime_configs)}"
+                config_content = runtime_configs[0].read_text(encoding="utf-8")
+                assert str(external_path) in config_content, "Runtime config should contain external test directory"
 
-                    assert len(roots_flags) > 0, "Expected --roots flag in Jest command"
+            clear_created_config_files()
 
-    def test_line_profile_tests_adds_roots_for_test_directories(self):
-        """Test that run_jest_line_profile_tests adds --roots for test directories."""
-        from codeflash.languages.javascript.test_runner import run_jest_line_profile_tests
+    def test_benchmarking_tests_creates_runtime_config_for_external_tests(self):
+        """Test that run_jest_benchmarking_tests creates a runtime config when tests are outside the project root."""
+        from codeflash.languages.javascript.test_runner import clear_created_config_files, get_created_config_files, run_jest_benchmarking_tests
         from codeflash.models.models import TestFile, TestFiles
         from codeflash.models.test_type import TestType
 
-        with tempfile.TemporaryDirectory() as tmpdir:
-            tmpdir_path = Path(tmpdir)
-            test_dir = tmpdir_path / "test"
-            test_dir.mkdir()
+        with tempfile.TemporaryDirectory() as project_dir, tempfile.TemporaryDirectory() as external_dir:
+            project_path = Path(project_dir).resolve()
+            external_path = Path(external_dir).resolve()
 
-            (tmpdir_path / "package.json").write_text('{"name": "test"}')
+            (project_path / "package.json").write_text('{"name": "test"}')
 
-            test_file = test_dir / "test_func__line_profile.test.ts"
-            test_file.write_text("// line profile test")
+            test_file = external_path / "test_func__perf_test_0.test.ts"
+            test_file.write_text("// perf test")
 
             mock_test_files = TestFiles(
                 test_files=[
@@ -165,6 +151,8 @@ def test_line_profile_tests_adds_roots_for_test_directories(self):
                 ]
             )
 
+            clear_created_config_files()
+
             with patch("subprocess.run") as mock_run:
                 mock_result = MagicMock()
                 mock_result.stdout = ""
@@ -173,63 +161,48 @@ def test_line_profile_tests_adds_roots_for_test_directories(self):
                 mock_run.return_value = mock_result
 
                 try:
-                    run_jest_line_profile_tests(
+                    run_jest_benchmarking_tests(
                         test_paths=mock_test_files,
                         test_env={},
-                        cwd=tmpdir_path,
-                        project_root=tmpdir_path,
+                        cwd=project_path,
+                        project_root=project_path,
                     )
                 except Exception:
                     pass
 
-                if mock_run.called:
-                    call_args = mock_run.call_args
-                    cmd = call_args[0][0]
-
-                    roots_flags = []
-                    for i, arg in enumerate(cmd):
-                        if arg == "--roots" and i + 1 < len(cmd):
-                            roots_flags.append(cmd[i + 1])
+                runtime_configs = [f for f in get_created_config_files() if "codeflash.runtime" in f.name]
+                assert len(runtime_configs) == 1, "Expected runtime config for external test files"
 
-                    assert len(roots_flags) > 0, "Expected --roots flag in Jest command"
+            clear_created_config_files()
 
-    def test_multiple_test_directories_all_added_to_roots(self):
-        """Test that multiple test directories are all added as --roots."""
-        from codeflash.languages.javascript.test_runner import run_jest_behavioral_tests
+    def test_line_profile_tests_creates_runtime_config_for_external_tests(self):
+        """Test that run_jest_line_profile_tests creates a runtime config when tests are outside the project root."""
+        from codeflash.languages.javascript.test_runner import clear_created_config_files, get_created_config_files, run_jest_line_profile_tests
         from codeflash.models.models import TestFile, TestFiles
         from codeflash.models.test_type import TestType
 
-        with tempfile.TemporaryDirectory() as tmpdir:
-            tmpdir_path = Path(tmpdir)
-            test_dir1 = tmpdir_path / "test"
-            test_dir2 = tmpdir_path / "spec"
-            test_dir1.mkdir()
-            test_dir2.mkdir()
+        with tempfile.TemporaryDirectory() as project_dir, tempfile.TemporaryDirectory() as external_dir:
+            project_path = Path(project_dir).resolve()
+            external_path = Path(external_dir).resolve()
 
-            (tmpdir_path / "package.json").write_text('{"name": "test"}')
+            (project_path / "package.json").write_text('{"name": "test"}')
 
-            test_file1 = test_dir1 / "test_func__unit_test_0.test.ts"
-            test_file2 = test_dir2 / "test_func__unit_test_1.test.ts"
-            test_file1.write_text("// test 1")
-            test_file2.write_text("// test 2")
+            test_file = external_path / "test_func__line_profile.test.ts"
+            test_file.write_text("// line profile test")
 
             mock_test_files = TestFiles(
                 test_files=[
                     TestFile(
-                        original_file_path=test_file1,
-                        instrumented_behavior_file_path=test_file1,
-                        benchmarking_file_path=test_file1,
-                        test_type=TestType.GENERATED_REGRESSION,
-                    ),
-                    TestFile(
-                        original_file_path=test_file2,
-                        instrumented_behavior_file_path=test_file2,
-                        benchmarking_file_path=test_file2,
+                        original_file_path=test_file,
+                        instrumented_behavior_file_path=test_file,
+                        benchmarking_file_path=test_file,
                         test_type=TestType.GENERATED_REGRESSION,
                     ),
                 ]
             )
 
+            clear_created_config_files()
+
             with patch("subprocess.run") as mock_run:
                 mock_result = MagicMock()
                 mock_result.stdout = ""
@@ -238,26 +211,19 @@ def test_multiple_test_directories_all_added_to_roots(self):
                 mock_run.return_value = mock_result
 
                 try:
-                    run_jest_behavioral_tests(
+                    run_jest_line_profile_tests(
                         test_paths=mock_test_files,
                         test_env={},
-                        cwd=tmpdir_path,
-                        project_root=tmpdir_path,
+                        cwd=project_path,
+                        project_root=project_path,
                     )
                 except Exception:
                     pass
 
-                if mock_run.called:
-                    call_args = mock_run.call_args
-                    cmd = call_args[0][0]
-
-                    roots_flags = []
-                    for i, arg in enumerate(cmd):
-                        if arg == "--roots" and i + 1 < len(cmd):
-                            roots_flags.append(cmd[i + 1])
+                runtime_configs = [f for f in get_created_config_files() if "codeflash.runtime" in f.name]
+                assert len(runtime_configs) == 1, "Expected runtime config for external test files"
 
-                    # Should have two --roots flags (one for each directory)
-                    assert len(roots_flags) == 2, f"Expected 2 --roots flags, got {len(roots_flags)}"
+            clear_created_config_files()
 
 
 class TestVitestTimeoutConfiguration: