Exit the cli if user doesn't have the formatter installed while running codeflash (CF-644)

[aseembits93]

PR Type

Bug fix

---

Description

• Exit CLI if formatter not installed

• Detect Black or uv formatter commands

• Import subprocess, sys, and click modules

• Gracefully handle missing executable errors

---

Changes walkthrough 📝

	Relevant files
Error handling	main.py Verify formatter installation at runtime                                  codeflash/main.py • Added subprocess, sys, and click imports • Checks if formatter command is Black or uv • Runs formatter to verify installation • Catches missing executable and exits +12/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review IndexError risk Directly accessing args.formatter_cmds[0] without validating that the list is non-empty can raise an IndexError if no formatter commands are provided. if args.formatter_cmds[0].startswith("black") or args.formatter_cmds[0].startswith("uv"): formatter = args.formatter_cmds[0].split(" ")[0] try: subprocess.run([formatter], capture_output=True, check=False) except (FileNotFoundError, NotADirectoryError): click.echo(f"⚠️ Formatter not found: {formatter}, please ensure it is installed") sys.exit(1) Formatter existence check Calling subprocess.run([formatter]) without evaluating its exit code or using shutil.which may not reliably detect whether the executable is present. if args.formatter_cmds[0].startswith("black") or args.formatter_cmds[0].startswith("uv"): formatter = args.formatter_cmds[0].split(" ")[0] try: subprocess.run([formatter], capture_output=True, check=False) except (FileNotFoundError, NotADirectoryError): click.echo(f"⚠️ Formatter not found: {formatter}, please ensure it is installed") sys.exit(1)

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Check list is non-empty first Guard against an empty formatter_cmds list to prevent an IndexError by ensuring it has at least one element before accessing index 0. codeflash/main.py [42] -if args.formatter_cmds[0].startswith("black") or args.formatter_cmds[0].startswith("uv"): +if args.formatter_cmds and (args.formatter_cmds[0].startswith("black") or args.formatter_cmds[0].startswith("uv")): Suggestion importance[1-10]: 7 __ Why: Guarding against an empty formatter_cmds list avoids a potential IndexError, improving robustness without much overhead.	Medium
General	Add version flag to formatter check Use a harmless flag like --version when invoking the formatter to avoid hangs or unexpected errors when no file argument is provided. This verifies installation without requiring actual formatting. codeflash/main.py [45] -subprocess.run([formatter], capture_output=True, check=False) +subprocess.run([formatter, "--version"], capture_output=True, check=False) Suggestion importance[1-10]: 6 __ Why: Adding --version prevents the formatter from hanging or attempting to read STDIN without arguments, improving the reliability of the check.	Low
	Use shlex for command parsing Use shlex.split to correctly parse the command string, handling quoted arguments or extra spaces more robustly. codeflash/main.py [43] -formatter = args.formatter_cmds[0].split(" ")[0] +import shlex +formatter = shlex.split(args.formatter_cmds[0])[0] Suggestion importance[1-10]: 5 __ Why: Using shlex.split more accurately parses command strings, though the impact is minor and the import placement may need adjustment.	Low

[aseembits93]

raising an OSError instead of a logger.error doesn't work somehow for me, works as expected though

[aseembits93]

Thanks @KRRT7 for the help!

[aseembits93]

@KRRT7 ready to merge

[aseembits93]

@KRRT7 ready to merge

[aseembits93]

tested with ruff and black