Claude.md#619
Closed
aseembits93 wants to merge 3 commits into
Closed
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
KRRT7
reviewed
Aug 6, 2025
Comment on lines
+1
to
+7
| # Bash commands | ||
| - `ruff check --fix --exit-non-zero-on-fix --config=pyproject.toml .`: Run the linter | ||
| - `ruff format .`: Run the formatter | ||
| - `mypy --non-interactive --config-file pyproject.toml @mypy_allowlist.txt`: mypy typechecker | ||
|
|
||
| # Running tests | ||
| - Run tests with `pytest tests/` |
Contributor
There was a problem hiding this comment.
these will all fail because we're using uv in order to run these commands, maybe using hooks is a better approach https://docs.anthropic.com/en/docs/claude-code/hooks-guide
Contributor
Author
|
will open it later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Documentation
Description
Add
Claude.mdwith linting and formatting commandsInclude
ruffandmypyinstructions for code checksAdd placeholder Code style section
Add workflow tips: typecheck and focused tests
File Walkthrough
Claude.md
Create Claude.md linting and workflow guideClaude.md
ruff check --fixandruff formatcommandsmypytypechecking instructions