-
Notifications
You must be signed in to change notification settings - Fork 25
display RO / RW context (--verbose) #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -508,7 +508,7 @@ def analyze_imports_in_test_file(test_file_path: Path | str, target_functions: s | |
| return True | ||
|
|
||
| if analyzer.found_any_target_function: | ||
| logger.debug(f"Test file {test_file_path} imports target function: {analyzer.found_qualified_name}") | ||
| # logger.debug(f"Test file {test_file_path} imports target function: {analyzer.found_qualified_name}") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why to keep the logs as comments when commenting.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just in case we want to bring them back |
||
| return True | ||
|
|
||
| # Be conservative with dynamic imports - if __import__ is used and a target function | ||
|
|
@@ -517,10 +517,10 @@ def analyze_imports_in_test_file(test_file_path: Path | str, target_functions: s | |
| # Check if any target function name appears as a string literal or direct usage | ||
| for target_func in target_functions: | ||
| if target_func in source_code: | ||
| logger.debug(f"Test file {test_file_path} has dynamic imports and references {target_func}") | ||
| # logger.debug(f"Test file {test_file_path} has dynamic imports and references {target_func}") | ||
| return True | ||
|
|
||
| logger.debug(f"Test file {test_file_path} does not import any target functions.") | ||
| # logger.debug(f"Test file {test_file_path} does not import any target functions.") | ||
| return False | ||
|
|
||
|
|
||
|
|
@@ -540,7 +540,7 @@ def filter_test_files_by_imports( | |
| if not target_functions: | ||
| return file_to_test_map | ||
|
|
||
| logger.debug(f"Target functions for import filtering: {target_functions}") | ||
| # logger.debug(f"Target functions for import filtering: {target_functions}") | ||
|
|
||
| filtered_map = {} | ||
| for test_file, test_functions in file_to_test_map.items(): | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.