Skip to content

⚡️ Speed up method TestFiles.get_test_type_by_instrumented_file_path by 2,276% in PR #1086 (fix-path-resolution/no-gen-tests) #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeflash-ai wants to merge 1 commit into from
Closed

⚡️ Speed up method TestFiles.get_test_type_by_instrumented_file_path by 2,276% in PR #1086 (fix-path-resolution/no-gen-tests) #1125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions codeflash/models/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,15 +384,7 @@ def get_by_original_file_path(self, file_path: Path) -> TestFile | None:

def get_test_type_by_instrumented_file_path(self, file_path: Path) -> TestType | None:
normalized = self._normalize_path_for_comparison(file_path)
for test_file in self.test_files:
normalized_behavior_path = self._normalize_path_for_comparison(test_file.instrumented_behavior_file_path)
if normalized == normalized_behavior_path:
return test_file.test_type
if test_file.benchmarking_file_path is not None:
normalized_benchmark_path = self._normalize_path_for_comparison(test_file.benchmarking_file_path)
if normalized == normalized_benchmark_path:
return test_file.test_type
return None
return self._path_to_test_type.get(normalized)

def get_test_type_by_original_file_path(self, file_path: Path) -> TestType | None:
normalized = self._normalize_path_for_comparison(file_path)
Expand Down Expand Up @@ -425,6 +417,16 @@ def __iter__(self) -> Iterator[TestFile]:
def __len__(self) -> int:
return len(self.test_files)

def __init__(self, **data):
super().__init__(**data)
self._path_to_test_type: dict[str, TestType] = {}
for test_file in self.test_files:
normalized_behavior_path = self._normalize_path_for_comparison(test_file.instrumented_behavior_file_path)
self._path_to_test_type[normalized_behavior_path] = test_file.test_type
if test_file.benchmarking_file_path is not None:
normalized_benchmark_path = self._normalize_path_for_comparison(test_file.benchmarking_file_path)
self._path_to_test_type[normalized_benchmark_path] = test_file.test_type


class OptimizationSet(BaseModel):
control: list[OptimizedCandidate]
Expand Down
Loading