feat: support glob patterns in ignore_paths configuration#1391
Merged
Conversation
Add support for glob patterns (e.g., `**/*.test.js`, `*.log`, `dist/*`) in the `ignore_paths` CLI option and configuration. Previously only literal paths were supported. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Saga4
reviewed
Feb 5, 2026
| GLOB_PATTERN_CHARS = frozenset("*?[") | ||
|
|
||
|
|
||
| def is_glob_pattern(path_str: str) -> bool: |
Contributor
There was a problem hiding this comment.
Great, Can refactor code in similar function like get_valid_subdirs as well.
Contributor
PR Review Summary✅ Prek ChecksAll linting and formatting checks passed successfully. ✅ Mypy Type ChecksNo type errors found in the new code added by this PR.
🔍 Code ReviewNo critical issues found. The implementation is clean and well-tested. Observations:
Existing Comment:
📊 Test CoverageChanged Files Coverage
New Code Coverage
Test Results
✅ SummaryThis PR successfully adds glob pattern support to Last updated: 2026-02-05 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignore_pathsCLI option and configuration**/*.test.js,*.log,dist/*workChanges
is_glob_pattern()function to detect glob pattern characters (*,?,[)normalize_ignore_paths()function that handles both literal paths and glob patternsUsage Examples
CLI:
Config (
pyproject.toml):Test plan
is_glob_pattern()functionnormalize_ignore_paths()function covering:*.log)**/*.py)dir/*)file?.txt)file[12].txt)🤖 Generated with Claude Code