-
Notifications
You must be signed in to change notification settings - Fork 26
refactor(java): replace regex/brace-counting with tree-sitter in instrumentation #1473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡️Codeflash found 24% (0.24x) speedup for
_strip_javadoc_commentsincodeflash/context/code_context_extractor.py⏱️ Runtime :
1.78 milliseconds→1.43 milliseconds(best of241runs)📝 Explanation and details
The optimized code achieves a 24% speedup by replacing regex-based pattern matching with a manual string scanning approach using Python's built-in
str.find()method.Key Optimization:
The original implementation uses
re.sub(r"/\*\*.*?\*/\s*", "", source, flags=re.DOTALL)which incurs significant overhead from:re.DOTALLflag enabling.to match newlines.*?) which requires backtrackingThe optimized version eliminates this overhead by:
str.find("/**")to locate Javadoc starts - a simple C-level string searchstr.find("*/", idx + 3)to find the closing delimiters[j].isspace()instead of regex\s*"".join(parts)Performance Characteristics:
str.find()is more efficient than regex backtrackingTrade-offs:
The optimization performs exceptionally well when Javadoc comments contain large amounts of text, or when there are relatively few comments to process. The slight regression on inputs with hundreds of consecutive small Javadocs is offset by dramatic gains on large comments and typical real-world Java source files with moderate documentation density.
The line profiler shows the optimized version spends most time in
str.find()calls (32.1% combined) and whitespace scanning (28.7%), which are still faster than the regex engine's 97.3% time consumption in the original.✅ Correctness verification report:
🌀 Click to see Generated Regression Tests
To test or edit this optimization locally
git merge codeflash/optimize-pr1473-2026-02-13T00.49.56Click to see suggested changes