-
Notifications
You must be signed in to change notification settings - Fork 26
fix: resolve jest-runner from project's node_modules for Jest 30 compatibility #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2e77f85
fix: resolve jest-runner from project's node_modules for Jest 30 comp…
mohammedahmed18 31e7116
Merge branch 'main' into fix/jest30-pnpm-resolution
mohammedahmed18 5694135
Update packages/codeflash/runtime/loop-runner.js
mohammedahmed18 2fb4b2d
cleaning up
mohammedahmed18 066980b
Merge branch 'fix/jest30-pnpm-resolution' of github.com:codeflash-ai/…
mohammedahmed18 2d73cf8
typo
mohammedahmed18 5e25b7f
debugging for failed workflow
mohammedahmed18 bfe4224
just for testing
mohammedahmed18 d13cdb5
fallback to directly require the jest-runner module inside the loop r…
mohammedahmed18 b4ea8b6
Update packages/codeflash/runtime/loop-runner.js
mohammedahmed18 c262f3c
Merge branch 'main' into fix/jest30-pnpm-resolution
mohammedahmed18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| # These version placeholders will be replaced by uv-dynamic-versioning during build. | ||
| __version__ = "0.20.0.post510.dev0+b8932209" | ||
| __version__ = "0.20.0.post634.dev0+2d73cf88" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug:
result.stderrwill always be""here because line 1046 creates a newCompletedProcesswithstderr="". The original stderr was merged intostdouton line 1043. This log line is misleading — it should either be removed or log the original stderr before it's merged.Or better yet, capture the original stderr before line 1046: