[FIX][JS] capturePerf shouldn't break when we have an external runner (batch size = 1)#1509
Merged
Merged
Conversation
Saga4
approved these changes
Feb 17, 2026
Contributor
PR Review SummaryPrek Checks✅ All checks pass — Mypy✅ No type errors found in changed Python files ( Code Review✅ No critical issues found. Changes reviewed:
Test Coverage
Overall Python coverage: 79% (2374 passed, 8 failed, 57 skipped) Notes:
Last updated: 2026-02-17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will fix the false positive issue we are having caused by the jest runner not actually executing the function inside the test case because capturePerf exited at the start of the first loop before calling
fn(..), which makes it look like it's much much faster than the original code