ci: verify unit-tests pass without JDK + matrix names (will close)#2048
Closed
KRRT7 wants to merge 5 commits into
Closed
ci: verify unit-tests pass without JDK + matrix names (will close)#2048KRRT7 wants to merge 5 commits into
KRRT7 wants to merge 5 commits into
Conversation
When matrix jobs are skipped, `${{ matrix.name }}` is never expanded,
showing literal "matrix.name" in the checks UI. Removing the `name:`
field lets GitHub use the job ID when skipped and auto-expand matrix
values when running.
Only 5 of 3,943 unit tests need Java, and they already have skip_if_maven_not_available() guards. Java execution is validated by the e2e-java job. Saves ~30-60s per matrix entry (7 entries).
Trivial whitespace change to codeflash/version.py to confirm determine-changes correctly detects code paths and all jobs run. Will be reverted after verification.
Contributor
Author
|
Throwaway verification PR — no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Throwaway PR to verify:
Includes trivial version.py change to trigger code-path CI jobs.
Will close after verification — do not merge.