Clean up Java test skip markers#2049
Merged
Merged
Conversation
KRRT7
force-pushed
the
ci/cleanup-test-markers
branch
from
402cd39 to
4cc9b68
Compare
- Remove dead `import shutil` from test_comparator.py - Rename `requires_java` → `requires_java_runtime` for consistency with test_run_and_parse.py - Remove redundant `@requires_java_runtime` on test_behavior_return_value_correctness (class already has it)
KRRT7
force-pushed
the
ci/cleanup-test-markers
branch
from
ae5937f to
da536db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import shutilfromtest_comparator.py(leftover fromshutil.which→_find_comparator_jarchange in ci: consolidate improvements — paths, validate-pr action, fetch-depth, continue-on-error #2047)requires_java→requires_java_runtimeintest_comparator.pyfor consistency withtest_run_and_parse.py@requires_java_runtimeontest_behavior_return_value_correctness— the class-level decorator already covers itTest plan
pytest tests/test_languages/test_java/ -v— 62 passed, 19 skipped, 0 failures