fix: increase API read timeout to prevent flaky E2E failures#2057
Merged
Conversation
…failures The flat 90s timeout was too aggressive for LLM-powered endpoints (/testgen, /optimize, /refinement) under load, causing ReadTimeoutError and failing the async-optimization E2E test. Split into (10s connect, 300s read) tuple so connections fail fast but LLM inference gets adequate time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.codeflash.aiendpoints(connect=10s, read=300s)tuple so connections fail fast but LLM inference gets adequate timeasync-optimizationE2E test caused byReadTimeoutErroron/testgenendpoint under loadRoot cause
AiServiceClientused a flattimeout=90for prod, passed to everyrequests.post()call. LLM-powered endpoints (/testgen,/optimize,/refinement, etc.) can legitimately exceed 90s when the backend is under load. When hit, the request raisesReadTimeoutError, test generation returnsNone, and the E2E test fails.Test plan
async-optimizationE2E test no longer flakes on timeout