Skip to content

Add license check#228

Closed
HeshamHM28 wants to merge 3 commits into
mainfrom
add-licensecheck
Closed

Add license check#228
HeshamHM28 wants to merge 3 commits into
mainfrom
add-licensecheck

Conversation

@HeshamHM28
Copy link
Copy Markdown
Contributor

@HeshamHM28 HeshamHM28 commented May 20, 2025

PR Type

Enhancement


Description

  • Add licensecheck dependency to project

Changes walkthrough 📝

Relevant files
Dependencies
pyproject.toml
Add licensecheck dependency                                                           

pyproject.toml

  • Added licensecheck = "^2025.1.0" under project dependencies
+1/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link
    Copy Markdown
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Dependency Scope

    licensecheck may be intended for development or CI use only and should be listed under dev-dependencies to avoid including it in production builds.

    licensecheck = "^2025.1.0"

    @github-actions
    Copy link
    Copy Markdown
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Move to dev-dependencies

    Move licensecheck into [tool.poetry.dev-dependencies] if it’s only used for
    build-time license validation to avoid bundling it in production installs.

    pyproject.toml [126]

    -licensecheck = "^2025.1.0"
     
    +
    Suggestion importance[1-10]: 5

    __

    Why: The suggestion improves package separation by keeping build-time tools out of production dependencies, but it’s a stylistic change with limited impact.

    Low

    @HeshamHM28 HeshamHM28 marked this pull request as draft May 20, 2025 01:31
    @HeshamHM28 HeshamHM28 closed this May 20, 2025
    Comment thread pyproject.toml
    types-pexpect = "^4.9.0.20241208"
    types-unidiff = "^0.7.0.20240505"
    uv = ">=0.6.2"
    licensecheck = { version = "^2025.1.0", markers = "python_version < '4.0'" }
    Copy link
    Copy Markdown
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Based on the readings, python 4 will never come as per their creators. So what's the point of this check?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants