propagate cf-api errors

[KRRT7]

PR Type

Bug fix

---

Description

• Remove custom 404 and 500 handlers

• Rely on req.raise_for_status() for errors

• Eliminate unused status code variables

---

Changes walkthrough 📝

	Relevant files
Error handling	cfapi.py Simplify error handling in get_blocklisted_functions          codeflash/api/cfapi.py Deleted not_found and internal_server_error variables Removed special-case 404/500 conditional blocks Now uses req.raise_for_status() for all HTTP errors +0/-9

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing return on error The exception handler logs errors but doesn’t return a value, causing the function to return None instead of a dict. It should return an empty dict or appropriate default on failure. try: req = make_cfapi_request(endpoint="/verify-existing-optimizations", method="POST", payload=information) req.raise_for_status() content: dict[str, list[str]] = req.json() except Exception as e: logger.error(f"Error getting blocklisted functions: {e}")

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Convert lists to sets and return Convert the lists in content to sets and explicitly return the resulting dict. This aligns the output with the declared return type and ensures the function returns a value. codeflash/api/cfapi.py [186-187] req.raise_for_status() content: dict[str, list[str]] = req.json() +return {filename: set(funcs) for filename, funcs in content.items()} Suggestion importance[1-10]: 9 __ Why: The function never returns a value on success and the annotation expects set[str], so converting lists to sets and returning fixes both the missing return and the type mismatch.	High
	Return empty dict on error Ensure the function always returns a dictionary on failure by adding a return statement in the exception block. This prevents it from implicitly returning None and breaking callers expecting a dict. codeflash/api/cfapi.py [188-189] except Exception as e: logger.error(f"Error getting blocklisted functions: {e}") + return {} Suggestion importance[1-10]: 7 __ Why: Without a return {} in the exception block, the function may implicitly return None, breaking callers expecting a dict.	Medium

[openhands-ai]

Looks like there are a few issues preventing this PR from being merged!

• GitHub Actions are failing:
  • end-to-end-test

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #241

Feel free to include any additional details that might help me get this PR into a better state.

_{^{You can manage your notification settings}}