Add a message informing the user about benchmark progress#247
Add a message informing the user about benchmark progress#247aseembits93 wants to merge 3 commits into
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
| if self.args.benchmark and num_optimizable_functions > 0: | ||
| with progress_bar(f"Running benchmarks in {self.args.benchmarks_root}", transient=True): | ||
| with progress_bar(f"Running benchmarks in {self.args.benchmarks_root}",transient=True): | ||
| logger.info(f"Running benchmarks in {self.args.benchmarks_root}") |
There was a problem hiding this comment.
this looks like a case where the above message prints in interactive console mode but doesn't in non-interactice consoles?
There was a problem hiding this comment.
I am closing this issue as this can be solved in Pycharm by selecting 'Emulate terminal in output console' in the run configuration
|
|
|
I am closing this issue as this can be solved in Pycharm by selecting 'Emulate terminal in output console' in the run configuration |
PR Type
Enhancement
Description
Simplify progress_bar call invocation
Move benchmark start message to logger.info
Changes walkthrough 📝
optimizer.py
Simplify progress_bar and add log messagecodeflash/optimization/optimizer.py
logger.infofor benchmark start