branchmark_root_check (CF-653)

[Saga4]

PR Type

Bug fix

---

Description

• Use config.get for benchmarks_root retrieval

• Strip whitespace before checking benchmarks_root

• Refine conditional to avoid empty string detection

---

Changes walkthrough 📝

	Relevant files
Bug fix	cmd_init.py Refine benchmarks_root presence check                                        codeflash/cli_cmds/cmd_init.py Replaced "benchmarks_root" in config with config.get(...).strip() Added benchmarks_root variable assignment Updated if check to ensure non-empty string +2/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review TypeError risk Calling .strip() on the result of config.get("benchmarks_root", "") can raise an error if the value in config is not a string (e.g., None). Consider casting to str or adding a type check before stripping. benchmarks_root = config.get("benchmarks_root", "").strip() if benchmarks_root and benchmarks_root != "": Redundant check The condition if benchmarks_root and benchmarks_root != "" is redundant because a non-empty string is truthy. You can simplify it to if benchmarks_root. benchmarks_root = config.get("benchmarks_root", "").strip() if benchmarks_root and benchmarks_root != "": benchmark_mode = inquirer_wrapper(

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Ensure safe string conversion Wrap the retrieved value in str() and use or "" to guard against non-string types, preventing an AttributeError when calling .strip(). codeflash/cli_cmds/cmd_init.py [517] -benchmarks_root = config.get("benchmarks_root", "").strip() +benchmarks_root = str(config.get("benchmarks_root") or "").strip() Suggestion importance[1-10]: 6 __ Why: Wrapping the config value with str(... or "") prevents AttributeError if a non-string is returned, adding useful type safety.	Low
General	Simplify string emptiness check Simplify the conditional by relying on the truthiness of benchmarks_root. The and benchmarks_root != "" check is redundant since an empty string is already falsy. codeflash/cli_cmds/cmd_init.py [517-518] benchmarks_root = config.get("benchmarks_root", "").strip() -if benchmarks_root and benchmarks_root != "": +if benchmarks_root: Suggestion importance[1-10]: 4 __ Why: The redundant benchmarks_root != "" check can be removed since empty strings are falsy in Python, simplifying the conditional.	Low