[Chore] warn message if the module root and test root are the same (CF-659)#266
Merged
mohammedahmed18 merged 9 commits intoJun 6, 2025
Conversation
| if should_modify_pyproject_toml(): | ||
| setup_info: SetupInfo = collect_setup_info() | ||
|
|
||
| if Path(setup_info.module_root).resolve() == Path(setup_info.tests_root).resolve(): |
Contributor
There was a problem hiding this comment.
do it when the user is actually entering the test directory, not after he is done.
Also remove the module_root path from the list of options when asking for the test_root. This will mostly solve the problem. We can still keep the warning in case the user enters the module_root path manually
mohammedahmed18
changed the title
misrasaurabh1
approved these changes
Jun 6, 2025
…odules-and-tests-same-path
…edahmed18/codeflash into chore/modules-and-tests-same-path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.