Skip to content

Rename the test files and Workflow name as all of them have same name#442

Merged
Saga4 merged 3 commits into
mainfrom
saga4/rename_e2e_workflow_files
Jun 26, 2025
Merged

Rename the test files and Workflow name as all of them have same name#442
Saga4 merged 3 commits into
mainfrom
saga4/rename_e2e_workflow_files

Conversation

@Saga4
Copy link
Copy Markdown
Contributor

@Saga4 Saga4 commented Jun 26, 2025 •
edited by github-actions Bot
Loading

PR Type

Enhancement

Description

  • Rename E2E workflow names for clarity

  • Introduce Coverage E2E workflow config

  • Validate workflow changes with trust gating

  • Set up Python and code optimization

Changes walkthrough 📝

Relevant files
Configuration changes
8 files
e2e-bubblesort-benchmark.yaml
Rename workflow to E2E - Bubble Sort Benchmark                     
+1/-1     
e2e-bubblesort-pytest-nogit.yaml
Rename workflow to E2E - Bubble Sort Pytest (No Git)         
+1/-1     
e2e-bubblesort-unittest.yaml
Rename workflow to E2E - Bubble Sort Unittest                       
+1/-1     
e2e-coverage-optimization.yaml
Add Coverage E2E workflow with validation and optimization
 [link]   
e2e-futurehouse-structure.yaml
Rename workflow to E2E - Futurehouse Structure                     
+1/-1     
e2e-init-optimization.yaml
Rename workflow to E2E - Init Optimization                             
+1/-1     
e2e-topological-sort.yaml
Rename workflow to E2E - Topological Sort                               
+1/-1     
e2e-tracer-replay.yaml
Rename workflow to E2E - Tracer Replay                                     
+1/-1     
Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    •

    @github-actions github-actions Bot added the workflow-modified This PR modifies GitHub Actions workflows label Jun 26, 2025
    @github-actions
    Copy link
    Copy Markdown
    Contributor

    github-actions Bot commented Jun 26, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Syntax Error

    The stray '+++' line at the top of the file appears to be a diff artifact and will break YAML parsing; it should be removed.

     
    name: Coverage E2E
    Setup Action

    The workflow uses 'astral-sh/setup-uv@v5' to install Python; verify this action supports the 'python-version' input or consider using the official 'actions/setup-python' for clarity.

     
    - name: Set up Python 3.11 for CLI
  uses: astral-sh/setup-uv@v5
  with:
    python-version: 3.11.6

    @github-actions
    Copy link
    Copy Markdown
    Contributor

    github-actions Bot commented Jun 26, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Add pull_request_target trigger

    Include a pull_request_target trigger scoped to workflow files so that the
    validation step runs with proper permissions when workflows themselves are modified.

    .github/workflows/e2e-coverage-optimization.yaml [3-8]

     on:
   pull_request:
     paths:
       - '**'
+  pull_request_target:
+    paths:
+      - '.github/workflows/**'
   workflow_dispatch:
    Suggestion importance[1-10]: 8

    __

    Why: Including pull_request_target for workflow file changes ensures the validation step runs with the correct token context and avoids permission issues.

    		Medium
    Simplify environment logic

    Move the complex inline expression into a top-level if condition on the job and use
    a static environment name for clarity and to avoid operator precedence pitfalls.

    .github/workflows/e2e-coverage-optimization.yaml [13]

    -environment: ${{ (github.event_name == 'workflow_dispatch' || (contains(toJSON(github.event.pull_request.files.*.filename), '.github/workflows/') && github.event.pull_request.user.login != 'misrasaurabh1' && github.event.pull_request.user.login != 'KRRT7')) && 'external-trusted-contributors' || '' }}
+if: >
+  github.event_name == 'workflow_dispatch'
+  || (contains(toJSON(github.event.pull_request.files.*.filename), '.github/workflows/')
+      && github.event.pull_request.user.login != 'misrasaurabh1'
+      && github.event.pull_request.user.login != 'KRRT7')
+environment: external-trusted-contributors
    Suggestion importance[1-10]: 4

    __

    Why: Moving the complex inline expression to an if and using a static environment improves readability, though it’s primarily a stylistic refactor.

    		Low
    Possible issue
    Fix workflow path regex

    Escape the dot in the grep pattern to correctly match the literal .github/workflows/
    path, since . in regex matches any character.

    .github/workflows/e2e-coverage-optimization.yaml [34]

    -if git diff --name-only "${{ github.event.pull_request.base.sha }}" "${{ github.event.pull_request.head.sha }}" | grep -q "^.github/workflows/"; then
+if git diff --name-only "${{ github.event.pull_request.base.sha }}" "${{ github.event.pull_request.head.sha }}" | grep -q "^\.github/workflows/"; then
    Suggestion importance[1-10]: 5

    __

    Why: The regex should escape the dot in “.github” to match the literal path correctly and avoid unintended matches.

    		Low

    @Saga4 Saga4 merged commit 64a40d8 into main Jun 26, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    1 more reviewer

    @KRRT7 KRRT7 KRRT7 approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    No one assigned

    Labels

    Review effort 2/5 workflow-modified This PR modifies GitHub Actions workflows

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @Saga4 @KRRT7