-
Notifications
You must be signed in to change notification settings - Fork 26
Fix for VSC windows #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix for VSC windows #948
Changes from 2 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
c53f2f6
windows fix in vsc correct function choosing from the file
mohamedashrraf222 f869b61
ensure the optimization starts for the function
mohamedashrraf222 da1fca0
using pathlib
mohamedashrraf222 f0b4657
formatting and linting fixes
mohamedashrraf222 d62462d
fix linting errors
mohamedashrraf222 8b4a5f5
FIX FAILING TEST
mohamedashrraf222 d2a2e96
fix linting error
mohamedashrraf222 3694c80
fixing one test after windows changes
mohamedashrraf222 5987a57
update the unicode delimiter to be windows compatible
mohamedashrraf222 1964abd
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohamedashrraf222 4344374
fix tests discovery in windows for vsc
mohamedashrraf222 9b78d88
fix Starting baseline establishment in windows
mohamedashrraf222 784378c
adding _manual_cleanup_worktree_directory
mohamedashrraf222 194bad5
Improved the manual cleanup function to handle Windows file locking a…
mohamedashrraf222 5e1b108
clean and optimize the git worktree deletion failure handling
mohamedashrraf222 7404d01
clean up added logs
mohamedashrraf222 5b2dfc1
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohamedashrraf222 dff190d
fix conflict
mohamedashrraf222 9833272
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohamedashrraf222 04fbab9
fix capture_mode for windows for failing tests
mohamedashrraf222 c443801
fix linting
mohamedashrraf222 9336f3b
fix linting
mohamedashrraf222 cc742fc
fix pre-commit errors
mohamedashrraf222 db8cb46
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohamedashrraf222 f824ea5
FIX for failing test test_function_discovery.py::test_filter_functions
mohamedashrraf222 e05aab2
removing git worktree logs
mohamedashrraf222 a12f002
fix linting after removing logs
mohamedashrraf222 52f19e4
Fixed inconsistent path resolution which can cause relative_to() chec…
mohamedashrraf222 bc779ff
Updated trace_benchmarks_pytest to use the same Windows-safe subproce…
mohamedashrraf222 ac35af3
pre-commit fixes
mohamedashrraf222 84d056d
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
Saga4 1d0802d
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
Saga4 df29969
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohammedahmed18 f5a46d7
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohamedashrraf222 db501da
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
Saga4 6371ca5
addressing all Required items by claude code review
mohamedashrraf222 397b741
fix linting
mohamedashrraf222 207d671
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohamedashrraf222 d896c90
Refactor path validation and error handling in discovery functions
mohamedashrraf222 d0c6c42
increasing timeout and changing comment
mohamedashrraf222 1973e07
revert not needed change
mohamedashrraf222 2d8654e
Restor debug statements
mohamedashrraf222 7732360
adding the Progress bar for test files and logger
mohamedashrraf222 67fcffc
adding the removed loggers
mohamedashrraf222 6be94a7
Refactor error handling in test discovery subprocess
mohamedashrraf222 79719ac
revert change
mohamedashrraf222 217b95a
update the comment of execute_test_subprocess
mohamedashrraf222 e0d9f57
revert not needed changes for initialize_function_optimization
mohamedashrraf222 4c9f51b
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohamedashrraf222 f75e353
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohamedashrraf222 16f176d
fix linting
mohamedashrraf222 1b96f51
Merge branch 'ashraf/cf-918-fix-vsc-extension-windows-bugs' of https:…
mohamedashrraf222 3fdcb35
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohamedashrraf222 2943537
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohamedashrraf222 cfc3363
Merge branch 'main' into ashraf/cf-918-fix-vsc-extension-windows-bugs
mohamedashrraf222 3345e2c
cleaning up
mohammedahmed18 56ffc37
Merge branch 'ashraf/cf-918-fix-vsc-extension-windows-bugs' of https:…
mohammedahmed18 ba46de2
formatting and linting
mohammedahmed18 01a868b
beautify
mohammedahmed18 6849554
format
mohammedahmed18 fc2ea80
fix conlict and merge main
mohamedashrraf222 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.