You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using group ${{ github.workflow }}-${{ github.ref }} may not cancel older runs for the same PR if github.ref differs between PR events and push events; consider ${{ github.workflow }}-${{ github.event.pull_request.head.ref || github.ref }} or ${{ github.workflow }}-${{ github.ref_name }} to consistently group by branch/PR.
The workflow is triggered by push, pull_request, and workflow_dispatch; verify that the chosen concurrency group prevents unintended cross-cancellation between branch pushes and PR runs from forks, or adjust to include repository/head_ref to avoid collisions.
cancel-in-progress only applies within the same concurrency group; ensure PR-only runs use a group keyed to the PR head ref so successive commits to the same PR cancel prior e2e runs as intended.
Replace github.ref in the concurrency group with github.ref_name to avoid creating separate groups for refs with different prefixes (e.g., refs/pull/... vs refs/heads/...). This ensures proper cancellation across retries and updates on the same PR/branch. Keep the workflow-scoped part to avoid cross-workflow cancellations.
Why: The existing_code matches the new hunk and the change to use github.ref_name improves concurrency grouping across events/refs without altering behavior otherwise. It's a solid maintainability/behavior fix but not critical.
Medium
Normalize concurrency group key
Use github.ref_name instead of github.ref so multiple runs of the same branch or PR share a concurrency group and cancel correctly. github.ref includes the refs/* prefix, fragmenting groups and defeating the cancel-in-progress intent.
Why: Correctly targets the added concurrency block and using github.ref_name will reduce fragmented groups, improving cancel-in-progress behavior; moderate impact, accurate fix.
Medium
Align group across events
Switch to github.ref_name to avoid differing group keys across event types (pull_request, workflow_dispatch) and ensure in-progress runs are actually canceled for the same PR/branch. This prevents parallel duplicates from slipping through.
Why: The snippet exists at the specified lines and the switch to github.ref_name is accurate and beneficial for consistent cancellation across event types, offering a meaningful but not critical improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Add concurrency groups to all workflows
Enable cancel-in-progress for PR runs
Reduce redundant CI runs on updates
Standardize concurrency config across pipelines
Diagram Walkthrough
File Walkthrough
12 files
Add workflow concurrency and cancel-in-progressAdd workflow concurrency and cancel-in-progressAdd workflow concurrency and cancel-in-progressAdd workflow concurrency and cancel-in-progressAdd workflow concurrency and cancel-in-progressAdd workflow concurrency and cancel-in-progressAdd workflow concurrency and cancel-in-progressAdd workflow concurrency and cancel-in-progressAdd workflow concurrency and cancel-in-progressAdd concurrency and cancel-in-progress to type checksAdd concurrency and cancel-in-progress to unit testsAdd concurrency and cancel-in-progress to Windows tests