Skip to content

⚡️ Speed up function insert_env_line by 71% #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function insert_env_line by 71% #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions higgsfield/internal/experiment/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,8 @@ def as_keyed_repo_url(repo_url: Optional[str], project_name: str) -> str:


def insert_env_line(keys: List[str], indent: str) -> str:
lines = []
for key in keys:
line = indent + "echo " + key + '="${{ secrets.' + key + ' }}" >> env'
lines.append(line)

# Use list comprehension and f-strings for improved performance and readability
lines = [f'{indent}echo {key}="${{{{ secrets.{key} }}}}" >> env' for key in keys]
return "\n".join(lines)


Expand Down Expand Up @@ -118,7 +115,6 @@ def generate(self, experiment_name: str, params: List[Param]):
),
)
)


print("Updated experiment action", experiment_name)

Expand All @@ -130,7 +126,13 @@ def _source_experiments(base_path: Path):
the same dependencies (aka environment) as the docker container.
"""
for file in base_path.glob("**/*.py"):
module_name = os.path.basename(file).split(".py")[0].split(".py")[0].replace(" ", "_").replace("-", "_")
module_name = (
os.path.basename(file)
.split(".py")[0]
.split(".py")[0]
.replace(" ", "_")
.replace("-", "_")
)
SourceFileLoader(module_name, str(file)).load_module()


Expand Down