Skip to content

Commit c6f0dc3

Browse files
style(desktop): neutralize dark source cards
1 parent 4e4f8c4 commit c6f0dc3

2 files changed

Lines changed: 15 additions & 3 deletions

File tree

apps/desktop/src/component-theme-contract.test.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,9 @@ describe("desktop component theme contract", () => {
159159
const darkSharedActive = cssBlock(
160160
':root[data-theme="dark"] .source-view-toggle button.active,\n:root[data-theme="dark"] .file-filter-bar button.active,\n:root[data-theme="dark"] .file-filter-bar button:hover,\n:root[data-theme="dark"] .activity-tabs button.active,\n:root[data-theme="dark"] .settings-nav button:hover,\n:root[data-theme="dark"] .settings-nav button.active,\n:root[data-theme="dark"] .theme-segmented button.active,\n:root[data-theme="dark"] .option-row:hover',
161161
);
162+
const darkSourceCards = cssBlock(
163+
':root[data-theme="dark"] .source-ready-card,\n:root[data-theme="dark"] .connector-choice-card.active,\n:root[data-theme="dark"] .mount-card.active',
164+
);
162165
const primaryButton = cssBlock(".primary-button");
163166
const primaryButtonHover = cssBlock(".primary-button:hover:not(:disabled)");
164167
const secondaryButtonHover = cssBlock(".secondary-button:hover:not(:disabled)");
@@ -190,6 +193,9 @@ describe("desktop component theme contract", () => {
190193
expectToken(settingsNavState, "color", "--control-selected-text");
191194
expectToken(darkSettingsNavSmall, "color", "--control-muted");
192195
expectToken(darkSharedActive, "box-shadow", "--surface-shadow");
196+
expectToken(darkSourceCards, "border-color", "--control-border-hover");
197+
expectToken(darkSourceCards, "background", "--surface-muted");
198+
expectToken(darkSourceCards, "color", "--ink");
193199
expectToken(primaryButton, "box-shadow", "--surface-shadow");
194200
expectToken(primaryButtonHover, "box-shadow", "--surface-shadow");
195201
expectToken(secondaryButtonHover, "box-shadow", "--surface-shadow");
@@ -213,6 +219,7 @@ describe("desktop component theme contract", () => {
213219
settingsActivityHover,
214220
settingsNavState,
215221
darkSettingsNavSmall,
222+
darkSourceCards,
216223
themeSegmentedActive,
217224
]) {
218225
expectNoRawColorValues(block);

apps/desktop/src/styles.css

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4587,15 +4587,20 @@ button.home-stat:hover {
45874587
:root[data-theme="dark"] .connector-option.available,
45884588
:root[data-theme="dark"] .connector-option.selectable:hover:not(:disabled),
45894589
:root[data-theme="dark"] .connector-option.selectable.selected,
4590-
:root[data-theme="dark"] .source-ready-card,
4591-
:root[data-theme="dark"] .connector-choice-card.active,
4592-
:root[data-theme="dark"] .mount-card.active,
45934590
:root[data-theme="dark"] .file-row.expanded {
45944591
border-color: var(--control-border-hover);
45954592
background: var(--surface-active);
45964593
color: var(--ink);
45974594
}
45984595

4596+
:root[data-theme="dark"] .source-ready-card,
4597+
:root[data-theme="dark"] .connector-choice-card.active,
4598+
:root[data-theme="dark"] .mount-card.active {
4599+
border-color: var(--control-border-hover);
4600+
background: var(--surface-muted);
4601+
color: var(--ink);
4602+
}
4603+
45994604
:root[data-theme="dark"] .connector-choice-card,
46004605
:root[data-theme="dark"] .connector-choice-card.mounted,
46014606
:root[data-theme="dark"] .workspace-path-row,

0 commit comments

Comments
 (0)