Merge pull request #142 from codeflash-ai/fix/calendar-event-filenames

Fix Google Calendar filenames for long event ids

Author: mohammedahmed18

crates/locality-google-calendar/src/connector.rs

@@ -17,6 +17,7 @@ use locality_core::model::{
 };
 use locality_core::planner::{PropertyValue, PushOperation, PushOperationKind};
 use locality_core::search::{RAW_SEARCH_METADATA_KEY, SearchMetadata};
+use locality_core::shadow::stable_hash;
 use locality_core::validation::ValidationIssue;
 use locality_core::{LocalityError, LocalityResult};
 use serde::{Deserialize, Serialize};
@@ -38,6 +39,8 @@ const LOCAL_DRAFT_REMOTE_ID: &str = "google-calendar-draft:local";
 const GOOGLE_CALENDAR_DRAFT_NATIVE_KIND: &str = "google_calendar_draft";
 const LOCAL_DRAFT_EVENT_ID: &str = "locality-google-calendar-draft-local";
 const LOCAL_DRAFT_CONFERENCE_REQUEST_ID: &str = "locality-google-calendar-conference-local";
+const EVENT_FILENAME_SLUG_MAX_LEN: usize = 96;
+const EVENT_FILENAME_HASH_LEN: usize = 16;
 
 #[derive(Clone, PartialEq, Eq)]
 pub struct GoogleCalendarConfig {
@@ -1119,7 +1122,23 @@ fn safe_slug(value: &str) -> String {
     if slug.is_empty() {
         "untitled".to_string()
     } else {
-        slug.to_string()
+        bound_slug(slug, value)
+    }
+}
+
+fn bound_slug(slug: &str, source: &str) -> String {
+    if slug.len() <= EVENT_FILENAME_SLUG_MAX_LEN {
+        return slug.to_string();
+    }
+
+    let hash = stable_hash(source);
+    let hash = &hash[..EVENT_FILENAME_HASH_LEN];
+    let prefix_len = EVENT_FILENAME_SLUG_MAX_LEN.saturating_sub(hash.len() + 1);
+    let prefix = slug[..prefix_len].trim_matches('-');
+    if prefix.is_empty() {
+        hash.to_string()
+    } else {
+        format!("{prefix}-{hash}")
     }
 }
 
@@ -1542,6 +1561,29 @@ google_calendar:
         );
     }
 
+    #[test]
+    fn event_filename_bounds_long_event_ids_to_filesystem_component_limit() {
+        let long_event_id = format!("loc{}", "a".repeat(1024));
+        let filename = super::event_filename(&event_fixture("event-1"), &long_event_id);
+        let event_id_hash = locality_core::shadow::stable_hash(&long_event_id);
+
+        assert!(
+            filename.len() <= 255,
+            "filename component must fit common filesystem limits: {}",
+            filename.len()
+        );
+        assert!(filename.starts_with("20260720-100000-design-review-"));
+        assert!(filename.ends_with(".md"));
+        assert!(
+            filename.len() < long_event_id.len(),
+            "long event ids should be shortened in filenames"
+        );
+        assert!(
+            filename.contains(&event_id_hash[..16]),
+            "shortened event ids should keep a stable hash suffix"
+        );
+    }
+
     #[test]
     fn apply_create_entity_inserts_primary_event_with_send_updates_and_meet() {
         let api = Arc::new(FakeGoogleCalendarApi::default());

crates/localityd/src/push.rs

@@ -39,7 +39,7 @@ use locality_core::push::{
 };
 use locality_core::shadow::{
     MarkdownBlockKind, ShadowBlock, ShadowDocument, rendered_bodies_equivalent,
-    segment_markdown_body,
+    segment_markdown_body, stable_hash,
 };
 use locality_core::validation::{ValidationIssue, ValidationReport};
 use locality_core::{LocalityError, LocalityResult};
@@ -82,6 +82,9 @@ use crate::virtual_fs::{
     virtual_mutation_content_path_for_read,
 };
 
+const CREATED_ENTITY_FILENAME_SLUG_MAX_LEN: usize = 96;
+const CREATED_ENTITY_FILENAME_HASH_LEN: usize = 16;
+
 pub fn execute_push_job<S, Source>(
     store: &mut S,
     job: PushJob,
@@ -4244,7 +4247,23 @@ fn created_entity_safe_slug(value: &str) -> String {
     if slug.is_empty() {
         "untitled".to_string()
     } else {
-        slug.to_string()
+        bound_created_entity_slug(slug, value)
+    }
+}
+
+fn bound_created_entity_slug(slug: &str, source: &str) -> String {
+    if slug.len() <= CREATED_ENTITY_FILENAME_SLUG_MAX_LEN {
+        return slug.to_string();
+    }
+
+    let hash = stable_hash(source);
+    let hash = &hash[..CREATED_ENTITY_FILENAME_HASH_LEN];
+    let prefix_len = CREATED_ENTITY_FILENAME_SLUG_MAX_LEN.saturating_sub(hash.len() + 1);
+    let prefix = slug[..prefix_len].trim_matches('-');
+    if prefix.is_empty() {
+        hash.to_string()
+    } else {
+        format!("{prefix}-{hash}")
     }
 }
 

crates/localityd/tests/push_execution.rs

@@ -1256,6 +1256,116 @@ fn daemon_push_reconciles_google_calendar_draft_create_to_canonical_event_filena
     );
 }
 
+#[test]
+fn daemon_push_reconciles_long_google_calendar_event_id_to_filesystem_safe_filename() {
+    let fixture = PushFixture::new();
+    let state_root = fixture.root.join(".state");
+    let source_path = Path::new("draft/design-review.md");
+    let content_root = virtual_fs_content_root(&state_root, &fixture.mount_id);
+    let cache_path =
+        virtual_fs_content_path(&state_root, &fixture.mount_id, source_path).expect("cache path");
+    fs::create_dir_all(cache_path.parent().expect("cache parent")).expect("cache parent");
+    fs::write(
+        &cache_path,
+        "---\ntitle: Design review\nsummary: Design review\nstart:\n  dateTime: \"2026-07-20T10:00:00-07:00\"\nend:\n  dateTime: \"2026-07-20T10:30:00-07:00\"\n---\nAgenda\n",
+    )
+    .expect("cache file");
+
+    let draft_folder_id = RemoteId::new("google-calendar-folder:draft");
+    let events_folder_id = RemoteId::new("google-calendar-folder:events");
+    let long_event_id = format!("loc{}", "a".repeat(1024));
+    let event_id_hash = locality_core::shadow::stable_hash(&long_event_id);
+    let created_remote_id = RemoteId::new(format!("google-calendar-event:primary:{long_event_id}"));
+    let mut store = InMemoryStateStore::new();
+    store
+        .save_mount(
+            MountConfig::new(fixture.mount_id.clone(), "google-calendar", &fixture.root)
+                .projection(ProjectionMode::LinuxFuse),
+        )
+        .expect("save mount");
+    store
+        .save_entity(EntityRecord::new(
+            fixture.mount_id.clone(),
+            draft_folder_id.clone(),
+            EntityKind::Directory,
+            "draft",
+            "draft",
+        ))
+        .expect("save draft folder");
+    store
+        .save_entity(EntityRecord::new(
+            fixture.mount_id.clone(),
+            events_folder_id.clone(),
+            EntityKind::Directory,
+            "events",
+            "events",
+        ))
+        .expect("save events folder");
+    store
+        .save_virtual_mutation(virtual_mutation(
+            &fixture.mount_id,
+            "local:calendar-draft",
+            VirtualMutationKind::Create,
+            None,
+            Some(draft_folder_id),
+            "draft/design-review.md",
+            Some(cache_path),
+        ))
+        .expect("save mutation");
+    let source = FakePushSource::default()
+        .with_created_entity(
+            created_remote_id.clone(),
+            rendered_google_calendar_entity(
+                created_remote_id.as_str(),
+                "Design review",
+                "2026-07-20T10:00:00-07:00",
+                "Agenda",
+            ),
+        )
+        .with_apply_effects(vec![JournalApplyEffect::CreatedEntity {
+            operation_id: PushOperationId("create-calendar-draft".to_string()),
+            operation_index: 0,
+            parent_id: events_folder_id,
+            entity_id: created_remote_id.clone(),
+        }]);
+
+    let report = execute_push_job_with_content_root(
+        &mut store,
+        PushJob {
+            target_path: fixture.root.join(source_path),
+            assume_yes: true,
+            confirm_dangerous: false,
+        },
+        &source,
+        Some(&state_root),
+    )
+    .expect("push google calendar draft with long event id");
+
+    assert_eq!(report.action, PushJobAction::Reconciled);
+    let event = store
+        .get_entity(&fixture.mount_id, &created_remote_id)
+        .expect("get created event")
+        .expect("created event entity");
+    let filename = event
+        .path
+        .file_name()
+        .expect("event filename")
+        .to_string_lossy();
+    assert!(
+        filename.len() <= 255,
+        "filename component must fit common filesystem limits: {}",
+        filename.len()
+    );
+    assert!(filename.starts_with("20260720-100000-design-review-"));
+    assert!(filename.ends_with(".md"));
+    assert!(
+        filename.contains(&event_id_hash[..16]),
+        "shortened event ids should keep a stable hash suffix"
+    );
+    assert!(content_root.join(&event.path).exists());
+    assert!(!content_root.join(source_path).exists());
+}
+
 #[test]
 fn daemon_push_accepts_google_calendar_summary_only_draft_create() {
     let fixture = PushFixture::new();