You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Include Slack recent.md pages in connector enumeration so plain-files pulls can materialize channel content.
Let directory-target pulls work for plain-files projections, recursively discover connector directories, and hydrate all missing/stub child pages under an explicit directory pull.
Skip refetching already-hydrated projected child pages during directory pulls, while still hydrating missing files and remaining stubs.
Preserve plain-files remote moves during directory pulls by reusing the mount-root move plan/rename behavior, including recursive connector directories.
Avoid rewriting existing stubs and avoid Notion-only missing-media repair for Slack pulls; update stub access polling so daemon rewrites do not look like user reads.
Give daemon pull requests a pull-specific 2-hour default timeout so large Slack hydration pulls can finish without racing a direct fallback.
Test Plan
cargo fmt --check
cargo test -q -p loc-cli commands::tests::daemon_request_timeout_for_uses_pull_specific_default
majorcrates/localityd/src/pull.rs:992
Plain directory pulls now hydrate every page child under non-database directories. That fixes Slack recent.md, but it also changes Google Docs folder pulls: after a root pull, loc pull <mount>/marketing will fetch and hydrate every stubbed Google Doc in that Drive folder, violating the existing online-only behavior for workspace folders and causing unexpected Docs API reads. Minimal fix: gate this auto-hydration to Slack or a connector capability, and add a Google Docs folder-pull test asserting nested docs remain stubs and docs.get_count() == 0.
majorcrates/localityd/src/pull.rs:1611 write_stub_if_needed now skips all existing page paths, including stale stub files. Previously, existing stubs were refreshed while non-stub local edits were preserved. With this change, a pull that sees updated remote title/version or connector-provided stub frontmatter updates the entity store but leaves the Markdown stub’s frontmatter stale; for row/property stubs this can expose old remote properties and later edits can be based on obsolete metadata. Minimal fix: only skip when the existing path is non-stub, or when the existing stub content exactly equals stub_markdown(entry). Add a test where an existing stub has old frontmatter and a pull rewrites it to the new stub without touching hydrated/non-stub files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recent.mdpages in connector enumeration so plain-files pulls can materialize channel content.Test Plan
cargo fmt --checkcargo test -q -p loc-cli commands::tests::daemon_request_timeout_for_uses_pull_specific_defaultcargo test -q -p loc-cli --test pullcargo test -q -p localityd pull::testscargo test -q -p locality-slackcargo build -q -p loc-cli -p localityd -p locality-slackcargo test --workspace --all-targets(rerun passed after one order-sensitive desktop test passed individually)git diff --check