You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
majorcrates/localityd/src/replica_materializer.rs:831
The v2 terminal control is parsed and validated, but its writable_metadata is then discarded and only ReplicaMaterializationSummary is returned. A scope-authorized export with writable entries will publish files without persisting the SQLite rows/baselines/preconditions needed for loc status, loc diff, or loc push, so local edits can become invisible or unpushable. Minimal fix: return the validated terminal writable metadata from materialization and persist it through the writable session store as part of sandbox init, with a test that a v2 export containing a write-enabled entry creates the expected local writable state.
majorcrates/locality-protocol/src/lib.rs:1438 validate_against_inventory only checks that each writable_entries item matches a delivered file; it does not check the reverse. A file can carry mutation-capable effective_actions in PAX/inventory but be omitted from writable_entries, and the client will accept the archive without the remote IDs/preconditions required to track or push edits for that write-enabled file. Minimal fix: require the set of mutation-capable delivered files to exactly match the writable metadata entries, or reject/downgrade files whose writable metadata is absent; add a negative protocol/materializer test for a mutable file omitted from writable_entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checkStacked on the Phase 1 public branch so existing hosted-media and profiling work remains intact.