Skip to content

Add bounded Notion root setup discovery - #125

Merged
misrasaurabh1 merged 4 commits into
mainfrom
codex/notion-root-setup
Jul 26, 2026
Merged

Add bounded Notion root setup discovery#125
misrasaurabh1 merged 4 commits into
mainfrom
codex/notion-root-setup

Conversation

@misrasaurabh1

Copy link
Copy Markdown
Contributor

Summary

  • add a synchronous metadata-only Notion root setup facade
  • bound advisory discovery to explicit provider-page and candidate ceilings
  • directly revalidate selected page/database identities without subtree traversal
  • document initial pre-replica discovery as a narrow onboarding exception

Validation

  • 7 focused root-setup tests
  • full locality-notion suite: 231 passed, 4 ignored
  • scoped strict clippy

Stacked on #124 because the private workspace pins that OAuth compatibility revision.

@vercel

vercel Bot commented Jul 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
locality Ready Ready Preview, Comment Jul 26, 2026 5:21am

@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codex review

  • minor: crates/locality-notion/src/root_setup.rs:144
    discover_candidates honors the candidate cap for returned pages, but the page search itself is still unbounded at the provider request level because NotionApi::search_pages always uses page_size: 100. A caller requesting max_candidates = 1 can still cause 100 page metadata records to be fetched before insert_pages truncates locally, which conflicts with the setup facade’s bounded-provider-work contract.
    Minimal fix: add a bounded page-search method mirroring search_databases_bounded, pass remaining.min(100) from root setup, and add a test that max_candidates = 1 sends page_size: 1 / does not retrieve extra page metadata.

@misrasaurabh1
misrasaurabh1 changed the base branch from codex/oauth-public-secret-safe to main July 26, 2026 07:11
@misrasaurabh1
misrasaurabh1 merged commit 11fc512 into main Jul 26, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant