Address PR review feedback on Slack alert

- Move notify_slack_of_exception below run() so definitions match call order
- Always print traceback (even when SLACK_WEBHOOK_URL is unset)
- Rename param tb_text -> traceback_text
- Drop empty-string default on GITHUB_REPOSITORY
- Extract MAX_TRACEBACK_CHARS constant with comment on Slack size limit
- Add APP_ENV (dev/prod) and GITHUB_EVENT_NAME to Slack message header
  so prod vs dev and scheduled vs manual runs are distinguishable
- Add APP_ENV to .env.example

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: MilesMorel

.env.example

@@ -3,4 +3,5 @@ INSTAGRAM_USERNAME=
 INSTAGRAM_PASSWORD=
 BLUESKY_HANDLE=
 BLUESKY_PASSWORD=
+APP_ENV=
 

.github/workflows/dev.yml

@@ -29,6 +29,7 @@ jobs:
           BLUESKY_HANDLE: ${{ secrets.BLUESKY_HANDLE }}
           BLUESKY_PASSWORD: ${{ secrets.BLUESKY_PASSWORD }}
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
+          APP_ENV: dev
         run: |
           #In order to create posts on the test accounts remove the --debugposters debug flag
           python ./main.py --debugsources --debugposters

.github/workflows/prod.yml

@@ -33,4 +33,5 @@ jobs:
           BLUESKY_PASSWORD: ${{ secrets.BLUESKY_PASSWORD }}
           MASTODON_TOKEN: ${{ secrets.MASTODON_TOKEN }}
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
+          APP_ENV: prod
         run: python ./main.py

main.py

@@ -23,33 +23,6 @@ def main():
         raise
 
 
-def notify_slack_of_exception(tb_text):
-    webhook_url = os.environ.get("SLACK_WEBHOOK_URL")
-    if not webhook_url:
-        print("SLACK_WEBHOOK_URL not set; skipping Slack alert.")
-        return
-
-    workflow = os.environ.get("GITHUB_WORKFLOW", "local run")
-    repo = os.environ.get("GITHUB_REPOSITORY", "")
-    run_id = os.environ.get("GITHUB_RUN_ID")
-    run_link = (
-        f"https://github.com/{repo}/actions/runs/{run_id}"
-        if repo and run_id
-        else None
-    )
-
-    header = f"CutePetsBoston run failed in *{workflow}*"
-    if run_link:
-        header += f" (<{run_link}|view run>)"
-    text = f"{header}\n```{tb_text.strip()[-2500:]}```"
-
-    try:
-        response = requests.post(webhook_url, json={"text": text}, timeout=10)
-        response.raise_for_status()
-    except Exception as slack_exc:
-        print(f"Failed to post Slack alert: {slack_exc}")
-
-
 def create_posters(debug=False):
     from social_posters.debug import PosterDebug
 
@@ -120,6 +93,42 @@ def pick_pet(pets):
     return random.choice(eligible)
 
 
+# Slack incoming-webhook messages have a ~40k-char limit; cap the traceback
+# well below that so the post stays readable and is never rejected.
+MAX_TRACEBACK_CHARS = 2500
+
+
+def notify_slack_of_exception(traceback_text):
+    print(traceback_text)
+
+    webhook_url = os.environ.get("SLACK_WEBHOOK_URL")
+    if not webhook_url:
+        print("SLACK_WEBHOOK_URL not set; skipping Slack alert.")
+        return
+
+    app_env = os.environ.get("APP_ENV", "local")
+    workflow = os.environ.get("GITHUB_WORKFLOW", "local run")
+    event = os.environ.get("GITHUB_EVENT_NAME")
+    repo = os.environ.get("GITHUB_REPOSITORY")
+    run_id = os.environ.get("GITHUB_RUN_ID")
+    run_link = (
+        f"https://github.com/{repo}/actions/runs/{run_id}"
+        if repo and run_id
+        else None
+    )
+
+    header = f"CutePetsBoston [{app_env}] run failed in *{workflow}*"
+    if event:
+        header += f" (trigger: {event})"
+    if run_link:
+        header += f" (<{run_link}|view run>)"
+    text = f"{header}\n```{traceback_text.strip()[-MAX_TRACEBACK_CHARS:]}```"
+
+    try:
+        response = requests.post(webhook_url, json={"text": text}, timeout=10)
+        response.raise_for_status()
+    except Exception as slack_exc:
+        print(f"Failed to post Slack alert: {slack_exc}")
 
 
 if __name__ == "__main__":