facet for links

Author: Jonny Johannes

social_posters/bluesky.py

@@ -149,21 +149,35 @@ def format_post(self, pet):
         )
     def _build_text_and_facets(self, post: Post) -> tuple[str, list]:
         body = post.text
-        facets = []
-
-        if not post.tags:
-            return body[:300], facets
-
-        tag_strings = [f"#{tag}" for tag in post.tags if tag]
-        tags_section = " ".join(tag_strings)
+        facets: list = []
         separator = "\n\n"
+        limit = 300
 
-        # Truncate body so the full text (body + separator + tags) fits in 300 chars.
-        max_body = 300 - len(separator) - len(tags_section)
-        full_text = f"{body[:max_body]}{separator}{tags_section}"
+        tag_strings = [f"#{tag}" for tag in (post.tags or []) if tag]
+        if tag_strings:
+            tags_section = " ".join(tag_strings)
+            # Truncate body so the full text (body + separator + tags) fits in limit chars.
+            max_body = limit - len(separator) - len(tags_section)
+            full_text = f"{body[:max_body]}{separator}{tags_section}"
+        else:
+            full_text = body[:limit]
 
-        # Compute byte offsets (AT Protocol facets use UTF-8 byte positions).
         encoded = full_text.encode("utf-8")
+
+        if post.link:
+            link_bytes = post.link.encode("utf-8")
+            link_idx = encoded.find(link_bytes)
+            if link_idx != -1:
+                facets.append({
+                    "index": {
+                        "byteStart": link_idx,
+                        "byteEnd": link_idx + len(link_bytes),
+                    },
+                    "features": [
+                        {"$type": "app.bsky.richtext.facet#link", "uri": post.link}
+                    ],
+                })
+
         search_from = 0
         for tag_str in tag_strings:
             tag_bytes = tag_str.encode("utf-8")
@@ -175,5 +189,6 @@ def _build_text_and_facets(self, post: Post) -> tuple[str, list]:
                 })
                 search_from = idx + len(tag_bytes)
 
+        facets.sort(key=lambda f: f["index"]["byteStart"])
         return full_text, facets
 

tests/test_bluesky.py

@@ -6,12 +6,41 @@ class TestBuildTextAndFacets:
     def setup_method(self):
         self.poster = PosterBluesky.__new__(PosterBluesky)
 
-    def test_no_tags_produces_no_facets(self):
+    def test_no_tags_no_link_produces_no_facets(self):
         post = Post(text="Hello, world!")
         text, facets = self.poster._build_text_and_facets(post)
         assert text == "Hello, world!"
         assert facets == []
 
+    def test_link_without_tags_produces_link_facet(self):
+        url = "https://example.com/adopt"
+        post = Post(text=f"Meet Poppy!\n\n{url}", link=url)
+        text, facets = self.poster._build_text_and_facets(post)
+
+        assert text == post.text
+        assert len(facets) == 1
+        enc = text.encode("utf-8")
+        f = facets[0]
+        assert enc[f["index"]["byteStart"] : f["index"]["byteEnd"]] == url.encode("utf-8")
+        assert f["features"][0]["$type"] == "app.bsky.richtext.facet#link"
+        assert f["features"][0]["uri"] == url
+
+    def test_link_and_tags_facets_sorted_by_byte_start(self):
+        url = "https://rg.org/pet/1"
+        post = Post(
+            text=f"Adopt me!\n\n{url}",
+            tags=["AdoptDontShop", "Boston", "DogsOfBluesky"],
+            link=url,
+        )
+        text, facets = self.poster._build_text_and_facets(post)
+
+        assert text.endswith("\n\n#AdoptDontShop #Boston #DogsOfBluesky")
+        assert len(facets) == 4
+        assert facets[0]["features"][0]["$type"] == "app.bsky.richtext.facet#link"
+        assert facets[0]["features"][0]["uri"] == url
+        for facet in facets[1:]:
+            assert facet["features"][0]["$type"] == "app.bsky.richtext.facet#tag"
+
     def test_tags_produce_facets_with_correct_byte_offsets(self):
         post = Post(text="Adopt me!", tags=["AdoptDontShop", "Boston", "DogsOfBluesky"])
         text, facets = self.poster._build_text_and_facets(post)