Merge pull request #1835 from Mephistic/fix-notif-object

Remove Old Notifications Functions

Author: Mephistic

functions/src/index.ts

@@ -36,8 +36,6 @@ export {
   populateTestimonySubmissionNotificationEvents,
   cleanupNotifications,
   deliverNotifications,
-  httpsDeliverNotifications,
-  httpsCleanupNotifications,
   updateUserNotificationFrequency
 } from "./notifications"
 

functions/src/notifications/cleanupNotifications.ts

@@ -67,22 +67,3 @@ const runCleanupNotifications = async () => {
 export const cleanupNotifications = functions.pubsub
   .schedule("every 24 hours")
   .onRun(runCleanupNotifications)
-
-export const httpsCleanupNotifications = functions.https.onRequest(
-  async (request, response) => {
-    try {
-      console.log("httpsCleanupNotifications triggered")
-      await runCleanupNotifications()
-      console.log("DEBUG: cleanupNotifications completed")
-
-      response
-        .status(200)
-        .send(
-          "Successfully cleaned up old notifications, topic events, and email documents"
-        )
-    } catch (error) {
-      console.error("Error in httpsCleanupNotifications:", error)
-      response.status(500).send("Internal server error")
-    }
-  }
-)

functions/src/notifications/deliverNotifications.ts

@@ -233,26 +233,11 @@ const renderToHtmlString = (digestData: NotificationEmailDigest) => {
     "utf8"
   )
   const compiledTemplate = handlebars.compile(templateSource)
-  return compiledTemplate({ digestData })
+  return compiledTemplate(digestData)
 }
 
 // Firebase Functions
 export const deliverNotifications = functions.pubsub
   .schedule("47 9 1 * 2") // 9:47 AM on the first day of the month and on Tuesdays
   .timeZone("America/New_York")
   .onRun(deliverEmailNotifications)
-
-export const httpsDeliverNotifications = functions.https.onRequest(
-  async (request, response) => {
-    try {
-      await deliverEmailNotifications()
-
-      console.log("DEBUG: deliverNotifications completed")
-
-      response.status(200).send("Successfully delivered notifications")
-    } catch (error) {
-      console.error("Error in deliverNotifications:", error)
-      response.status(500).send("Internal server error")
-    }
-  }
-)

functions/src/notifications/index.ts

@@ -2,14 +2,8 @@
 import { publishNotifications } from "./publishNotifications"
 import { populateBillHistoryNotificationEvents } from "./populateBillHistoryNotificationEvents"
 import { populateTestimonySubmissionNotificationEvents } from "./populateTestimonySubmissionNotificationEvents"
-import {
-  cleanupNotifications,
-  httpsCleanupNotifications
-} from "./cleanupNotifications"
-import {
-  deliverNotifications,
-  httpsDeliverNotifications
-} from "./deliverNotifications"
+import { cleanupNotifications } from "./cleanupNotifications"
+import { deliverNotifications } from "./deliverNotifications"
 import { updateUserNotificationFrequency } from "./updateUserNotificationFrequency"
 
 // Export the functions
@@ -19,7 +13,5 @@ export {
   populateTestimonySubmissionNotificationEvents,
   cleanupNotifications,
   deliverNotifications,
-  httpsDeliverNotifications,
-  httpsCleanupNotifications,
   updateUserNotificationFrequency
 }