Fix Bill History Scraper (#2123)

* allow date to be nullable on billHistory items

* formatting

Author: ACoullard

components/bill/HistoryTable.tsx

@@ -37,7 +37,7 @@ const BillHistoryActionRows = ({ billHistory }: HistoryProps) => {
         return (
           <tr key={index}>
             <td>
-              {Date.substring(5, 10)}-{Date.substring(0, 4)}
+              {Date ? `${Date.substring(5, 10)}-${Date.substring(0, 4)}` : ""}
             </td>
             <td>
               <LinkConnectedBills action={Action} />

components/bill/Status.tsx

@@ -38,14 +38,8 @@ export const Status = ({ bill }: BillProps) => {
     hearingCheck = true
   }
 
-  let hearingDate = ""
-  if (history?.Date) {
-    hearingDate = history.Date
-  }
-  let dateCheck = false
-  if (hearingDate < today) {
-    dateCheck = true
-  }
+  const hearingDate = history?.Date ?? ""
+  const dateCheck = !!hearingDate && hearingDate < today
 
   if (!history) return null
   return (

functions/src/bills/types.ts

@@ -19,7 +19,7 @@ export const BillReference = Record({
 
 export type BillHistoryAction = Static<typeof BillHistoryAction>
 export const BillHistoryAction = Record({
-  Date: String,
+  Date: Nullable(String),
   Branch: String,
   Action: String
 })