Remove flask API from firebase functions (#1998)

* Remove flask API from firebase functions

* Add top-level comment to main.py

Author: chiroptical

llm/main.py

@@ -1,8 +1,11 @@
-from flask import Flask, jsonify, abort, request
-from llm_functions import get_summary_api_function, get_tags_api_function
-import json
+"""
+The module contains all of the Python based Firebase functions
+
+* add_summary_on_document_created - when new bills are written to the database, this function will trigger via on_document_created
+"""
+
 from firebase_admin import initialize_app
-from firebase_functions import https_fn, options
+from firebase_functions import options
 import os
 from firebase_functions.firestore_fn import (
     on_document_created,
@@ -12,7 +15,6 @@
 import bill_on_document_created
 
 initialize_app()
-app = Flask(__name__)
 
 
 def is_intersection(keys, required_keys):
@@ -29,56 +31,6 @@ def set_openai_api_key():
                 os.environ["OPENAI_API_KEY"] = os.environ["OPENAI_DEV"]
 
 
-@app.route("/summary", methods=["POST"])
-def summary():
-    set_openai_api_key()
-    body = json.loads(request.data)
-    # We require bill_id, bill_title, bill_text to exist as keys in the POST
-    if not is_intersection(body.keys(), {"bill_id", "bill_title", "bill_text"}):
-        abort(404, description="requires bill_id, bill_title, and bill_text")
-
-    summary = get_summary_api_function(
-        body["bill_id"], body["bill_title"], body["bill_text"]
-    )
-
-    if summary["status"] in [-1, -2]:
-        abort(500, description="Unable to generate summary")
-
-    return jsonify(summary["summary"])
-
-
-@app.route("/tags", methods=["POST"])
-def tags():
-    set_openai_api_key()
-    body = json.loads(request.data)
-    # We require bill_id, bill_title, bill_text to exist as keys in the POST
-    # Note: & is essentially set intersection
-    if not is_intersection(body.keys(), {"bill_id", "bill_title", "bill_text"}):
-        abort(404, description="requires bill_id, bill_title, and bill_text")
-
-    tags = get_tags_api_function(body["bill_id"], body["bill_title"], body["bill_text"])
-
-    if tags["status"] in [-1, -2]:
-        abort(500, description="Unable to generate tags")
-
-    return jsonify(tags["tags"])
-
-
-@app.route("/ready", methods=["GET"])
-def ready():
-    return ""
-
-
-@https_fn.on_request(
-    secrets=["OPENAI_DEV", "OPENAI_PROD"],
-    timeout_sec=300,
-    memory=options.MemoryOption.GB_1,
-)
-def httpsflaskexample(req: https_fn.Request) -> https_fn.Response:
-    with app.request_context(req.environ):
-        return app.full_dispatch_request()
-
-
 @on_document_created(
     secrets=["OPENAI_DEV", "OPENAI_PROD"],
     timeout_sec=300,

llm/readme.md

@@ -170,30 +170,14 @@ in the emulator after running `yarn dev:up`.
 # had a number of problems with authorization
 GOOGLE_APPLICATION_CREDENTIALS=/path/to/application_default_credentials.json \
   firebase deploy --only functions:maple-llm --debug
-
-# Hit the function in production
-curl \
-  -X POST \
-  -H "Content-Type: application/json" \
-  -H "Authorization: Bearer $(gcloud auth print-identity-token)" \
-  -d '{"bill_id": "1234","bill_title": "A title","bill_text": "Some bill text"}' \
-  https://httpsflaskexample-ke6znoupgq-uc.a.run.app/summary
 ```
 
 ## Future work
 
-Currently, we are just using the built-in Flask server. We should switch to a
-production WSGI server, like `gunicorn`.
-
 The local emulator installation process is quite cumbersome and ideally the
 virtual environment was built during container instantiation instead of from
 within the Docker container (i.e. the "Deploying locally" docs above).
 
-The current API is a little wonky because we take `bill_id` **and** `bill_text`.
-We could just look up the `bill_text` via the `bill_id` using the Firestore API.
-It might make sense to avoid the HTTP wrapper all-together and figure out how
-JS <-> Python communication works without an HTTP layer.
-
 ## Document triggers
 
 The first trigger is an `@on_document_created` trigger in