This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Take Photo #7
Open
nelsontloz wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
@SmilingKat please take a look. |
|
Hi Nelson sounds like a lot of progress. Can e do s chat next week to fall about bigger picture?
Regards,
John.
Please excuse brevity or typos as sent from my Windows 10 phone.
…________________________________
From: Nelson Alcocer <notifications@github.com>
Sent: Saturday, November 10, 2018 3:12:34 PM
To: codeforireland2/vacanthomes_mobileend
Cc: Subscribed
Subject: [codeforireland2/vacanthomes_mobileend] Take Photo (#7)
#4<#4>
________________________________
You can view, comment on, or merge this pull request online at:
#7
Commit Summary
* Added button to upload images from the device.
* Improved upload button, it extends all functionality from antd-mobile button component.
* Fixed warning with touch event in chrome and disable behavior.
* Removed mock from tests.
File Changes
* M src/App.tsx<https://github.com/codeforireland2/vacanthomes_mobileend/pull/7/files#diff-0> (36)
* A src/components/PictureUploadButton.scss<https://github.com/codeforireland2/vacanthomes_mobileend/pull/7/files#diff-1> (12)
* A src/components/PictureUploadButton.test.tsx<https://github.com/codeforireland2/vacanthomes_mobileend/pull/7/files#diff-2> (9)
* A src/components/PictureUploadButton.tsx<https://github.com/codeforireland2/vacanthomes_mobileend/pull/7/files#diff-3> (50)
Patch Links:
* https://github.com/codeforireland2/vacanthomes_mobileend/pull/7.patch
* https://github.com/codeforireland2/vacanthomes_mobileend/pull/7.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#7>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHGWhfDIWMRLA5Jcbd0jz9nDyg1wGC5mks5utuzigaJpZM4YYBik>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4