optimized hasRolePermission() method

UnderlineWords · UnderlineWords · commit a8989fe58c84 · 2021-03-23T00:37:09.000+03:00
diff --git a/Traits/PermissionTrait.php b/Traits/PermissionTrait.php
@@ -27,9 +27,6 @@ public function hasPermission($permission): bool
     public function hasRolePermission($permission): bool
     {
         if(!isset($this->roles))
-            return false;
-
-        if((bool)$this->roles()->count())
             foreach($this->roles as $role)
                 return $role->hasPermission($permission);
 

Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,6 @@ public function hasPermission($permission): bool`
`27`	`27`	`public function hasRolePermission($permission): bool`
`28`	`28`	`{`
`29`	`29`	`if(!isset($this->roles))`
`30`		`- return false;`
`31`		`-`
`32`		`- if((bool)$this->roles()->count())`
`33`	`30`	`foreach($this->roles as $role)`
`34`	`31`	`return $role->hasPermission($permission);`
`35`	`32`