merged master

Author: Alan Hermanns

src/backend/expungeservice/form_filling.py

@@ -616,7 +616,6 @@ class FormFilling:
     COUNTIES_NEEDING_CONVICTION_OR_ARREST_ORDER = ["multnomah"]
     COUNTIES_NEEDING_COUNTY_SPECIFIC_DOWNLOAD_NAME : List[str] = []
     OSP_PDF_NAME = "OSP_Form"
-    #COMPILED_PDF_NAME = "COMPILED_MOTIONS"
 
     @staticmethod
     def build_zip(record_summary: RecordSummary, user_information_dict: Dict[str, str], summary: bytes, summary_filename: str) -> Tuple[str, str]:
@@ -649,20 +648,11 @@ def build_zip(record_summary: RecordSummary, user_information_dict: Dict[str, st
         osp_file_info = FormFilling._create_and_write_pdf(user_information_dict_2, temp_dir)
         zip_file.write(*osp_file_info[0:2])
 
-        #todo: refactor and build separate method to compose compiled
         if all_motions_to_set_aside:
-            compiled = PdfWriter()
-            compiled.addpages(PdfReader(all_motions_to_set_aside.pop(0)[0]).pages)
-            for f in all_motions_to_set_aside:
-                compiled.addpages(PdfReader(f[0]).pages)
-
-            compiled.addpages(PdfReader(osp_file_info[0]).pages)
-
-            compiled.trailer.Root.AcroForm = PdfDict(NeedAppearances=PdfObject("true"))
-
+            file_paths = [f[0] for f in all_motions_to_set_aside] + [osp_file_info[0]]
             comp_name = "COMPILED.pdf"
             comp_path = path.join(temp_dir, comp_name)
-            compiled.write(comp_path)
+            FormFilling.compile_pdfs(file_paths, comp_path)
             zip_file.write(comp_path, comp_name)
 
 
@@ -673,6 +663,31 @@ def build_zip(record_summary: RecordSummary, user_information_dict: Dict[str, st
 
         return zip_path, zip_file_name
 
+    @staticmethod
+    def rename_fields(reader: PdfReader, start_index: int) -> int:
+        acro_form = reader.Root.AcroForm
+        if not acro_form or not acro_form.Fields:
+            return 0
+        fields = acro_form.Fields
+        for i, field in enumerate(fields):
+            if field.get(PdfName('T')):
+                old_name = field[PdfName('T')].to_unicode()
+                new_name = f"{old_name}_{start_index + i}"
+                field[PdfName('T')] = new_name
+        return len(fields)
+
+    @staticmethod
+    def compile_pdfs(file_paths: List[str], output_path: str) -> None:
+        compiled = PdfWriter()
+        start_index = 0
+        for file_path in file_paths:
+            reader = PdfReader(file_path)
+            field_count = FormFilling.rename_fields(reader, start_index)
+            start_index += field_count
+            compiled.addpages(reader.pages)
+        compiled.trailer.Root.AcroForm = PdfDict(NeedAppearances=PdfObject("true"))
+        compiled.write(output_path)
+
     @staticmethod
     def build_summary_filename(aliases):
         first_alias = aliases[0]

src/backend/expungeservice/form_filling_2026.py

@@ -17,8 +17,6 @@
 from typing import Any, Dict, List, Optional, Tuple
 from zipfile import ZipFile
 
-from pdfrw import PdfReader, PdfWriter, PdfDict, PdfObject
-
 from expungeservice.form_filling import (
     CaseResults,
     DA_ADDRESSES,
@@ -124,7 +122,7 @@ def extra_mappings(self):
             "(defendant_name)": s.case_name,
             "(dob)": s.date_of_birth,
             "(sid_number)": s.sid or "",
-            "(law_enforcement_agency)": "Not Known",  # Per guidance, to avoid rejection
+            "(law_enforcement_agency)": "",  # Left blank, to avoid attracting attention
             "(arrest_date)": first_arrest_date,
             "(fpn_number)": "",  # Leave blank
 
@@ -325,18 +323,10 @@ def build_zip(
 
         # Build compiled PDF
         if all_motions_to_set_aside:
-            compiled = PdfWriter()
-            compiled.addpages(PdfReader(all_motions_to_set_aside.pop(0)[0]).pages)
-            for f in all_motions_to_set_aside:
-                compiled.addpages(PdfReader(f[0]).pages)
-
-            compiled.addpages(PdfReader(osp_file_info[0]).pages)
-
-            compiled.trailer.Root.AcroForm = PdfDict(NeedAppearances=PdfObject("true"))
-
+            file_paths = [f[0] for f in all_motions_to_set_aside] + [osp_file_info[0]]
             comp_name = "COMPILED.pdf"
             comp_path = path.join(temp_dir, comp_name)
-            compiled.write(comp_path)
+            OldFormFilling.compile_pdfs(file_paths, comp_path)
             zip_file.write(comp_path, comp_name)
 
         # Add summary PDF

src/backend/expungeservice/waiver_form_filling.py

@@ -10,7 +10,7 @@
 
 from expungeservice.models.record_summary import RecordSummary
 from expungeservice.models.case import Case
-from expungeservice.form_filling import DA_ADDRESSES
+from expungeservice.form_filling import DA_ADDRESSES, FormFilling
 
 def wrap_text(text):
     text = re.sub(r'\r\n?|\n', ' ', text)
@@ -84,6 +84,7 @@ def build_zip(
         zip_path = path.join(mkdtemp(), zip_file_name)
         zip_file = ZipFile(zip_path, "w")
 
+        all_waiver_files = []
         for case in record_summary.record.cases:
             if (
                 case.summary.balance_due_in_cents > 0
@@ -92,6 +93,13 @@ def build_zip(
                 case_data = CaseData(case, user_information_dict, waiver_information_dict)
                 file_info = WaiverFormFilling._create_and_write_pdf(case_data, temp_dir)
                 zip_file.write(*file_info[0:2])
+                all_waiver_files.append(file_info)
+
+        if all_waiver_files:
+            file_paths = [f[0] for f in all_waiver_files]
+            comp_path = path.join(temp_dir, "COMPILED_FINES_AND_FEES.pdf")
+            FormFilling.compile_pdfs(file_paths, comp_path)
+            zip_file.write(comp_path, "COMPILED_FINES_AND_FEES.pdf")
 
         zip_file.close()