[Bug Fix] - Fix Main Layout Spacing and Navigation#1802
Merged
Conversation
…gation within an aside element and adjust their padding and order; Update nav menu logic to close menu when changing routes
Contributor
|
Thanks Ka Hung! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the spacing for the existing layout for the main content (3rd screenshot) and updates the nav menu logic for mobile (see 4th screenshot).
Issue
Previously, the site on production had a bug where the content was under the navbar as opposed to be placed below the navbar (see first screenshot). There was also an issue on mobile where the menu doesn't collapse after navigating, forcing users to click the close button explicitly (see second screenshot).
Screenshots
Screen.Recording.2026-01-15.at.2.55.28.AM.mov
Screen.Recording.2026-01-15.at.2.58.58.AM.mov
Screen.Recording.2026-01-15.at.9.23.07.AM.mov
Screen.Recording.2026-01-15.at.9.22.40.AM.mov